Skip to content

fix(callbacks): wrap log and metric callbacks - #1221

Merged
solnic merged 4 commits into
fix/wrap-event-pipeline-callbacksfrom
fix/wrap-log-and-metric-callbacks
Sep 23, 2026
Merged

fix(callbacks): wrap log and metric callbacks#1221
solnic merged 4 commits into
fix/wrap-event-pipeline-callbacksfrom
fix/wrap-log-and-metric-callbacks

Conversation

@solnic

@solnic solnic commented Sep 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Now before_send_log and before_send_metric run through Sentry.Callback and any crash is logged as an error with :sentry log domain - the log event or metric is dropped.

Furthemore, callback crashes go out as client reports with the callback_error reason set.

@solnic
solnic added this pull request to stack #1225 September 22, 2026 07:48
@solnic solnic changed the title Fix/wrap log and metric callbacks fix(callbacks): wrap log and metric callbacks Sep 22, 2026
@solnic
solnic marked this pull request as ready for review September 22, 2026 08:50
@solnic
solnic force-pushed the fix/wrap-log-and-metric-callbacks branch from c6e9edf to 4a4a754 Compare September 22, 2026 10:06
@solnic
solnic force-pushed the fix/wrap-log-and-metric-callbacks branch from 4a4a754 to bba6658 Compare September 23, 2026 14:43
@solnic
solnic merged commit 2bd33c3 into master Sep 23, 2026
16 checks passed
@solnic
solnic deleted the fix/wrap-log-and-metric-callbacks branch September 23, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@solnic @sl0thentr0py