feat(android-nav3): [Android Nav3 2] Model navigation routes - #6130
0xadam-brown merged 5 commits into
Conversation
|
📲 Install BuildsAndroid
|
e5d13ee to
1b98b50
Compare
dc5546c to
b0eb957
Compare
| * Doing so prevents route names from being obfuscated while leaving per-route arguments to | ||
| * [RouteArgumentsExtractor]. | ||
| */ | ||
| @ApiStatus.Experimental |
There was a problem hiding this comment.
Marked as experimental b/c this will be made public in a follow-on to the current PR stack. (Same below.)
runningcode
left a comment
There was a problem hiding this comment.
before I give it a deeper look or maybe we can answer these in our session later, since I'm not a compose expert, what's the threading behavior on this? are these always called from the main thread since this is UI stuff?
One more question is that I wonder if it is safe to call the logger from inside the catch clause. I know we've had situations in the past where this was unsafe due to the SO/recursion risk.
The issue is that the logger also has user callbacks in the form of BeforeSendLogCallback and is therefore unsafe in the same way that the user callbacks are.
markushi
left a comment
There was a problem hiding this comment.
Looking good, left two minor commments.
b0eb957 to
4038ff4
Compare
Introduce the route translation layer for Navigation 3 so later stages can reason about route names and sanitized arguments in one place. At this stage the module still exposes no meaningful public API surface.
4038ff4 to
01c0ad0
Compare
Convert the new Navigation 3 route test assertions from kotlin.test to Google Truth to match the repository's preferred unit-test assertion style. Co-Authored-By: OpenAI GPT-5.4 <noreply@openai.com>
Add a RetentionPolicy enum to RouteTranslator.translate so callers can declare whether route info for the lower or higher values in the provided list should be retained when an extraction budget is reached. dThis removes the implicit newest-first coupling while preserving the existing shared argument budget behavior for the top of the stack.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 16726da. Configure here.
Both We could in theory do the route translation work on a background thread (eg, by using a properly dispatched
(I've added a "Threading policy" section to the class KDoc.)
Great question, but I'm not worried in our case. All the logs here use |
5c8bd0a
into
feat/sentry-nav3-effect-stack

PR Stack (Android Nav3)
📜 Description
To support Nav3 we have to map a host app's back stack to an internal representation suitable for the Sentry data we emit. This PR introduces the core logic for doing so in the form of a
RouteTranslator.Note that the
RouteResolverspassed to the translators constructor are defined by the host app, and so we're careful to protect against misuse / unintended performance issues.💡 Motivation and Context
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Build the observer layer that consumes these routes and updates Sentry state.
#skip-changelog