Conversation
Skip replay capture when beforeErrorSampling throws instead of capturing replay after a failed user filter. Continue sending the error event and retain existing exception logging and catch types. Cover handled errors, crashes, and successful replay capture after a previous callback failure. Verify error delivery and failure logging. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
This was referenced Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Callback Errors)
📜 Description
Skip replay capture when
beforeErrorSamplingthrows, while continuing to send the error event. Update the error log to reflect that replay capture is skipped.Callbacks returning
trueorfalse, and configurations without a callback, retain their existing behavior. The existing catch type and reentrancy guard are unchanged; subsequent events can still trigger replay capture.💡 Motivation and Context
A failed user replay filter must not trigger replay capture. Previously, throwing from
beforeErrorSamplingproceeded with capture, potentially sending replay data the callback intended to exclude.💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew :sentry:apiCheck :sentry:test --tests='*SentryClientTest*' --tests='*SentryClientInternalEventProcessorTest*' --tests='*SentryReplayOptionsTest*'— 276 tests passed📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Profile discard accounting and profile/replay artifact cleanup remain separate follow-ups. Callback-boundary catch-type changes remain deferred to the next major.