Repository navigation
feat(android): Add experimental Cronet request instrumentation - #6185
Closed
sentry-junior[bot] wants to merge 3 commits into
Closed
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: David Quintas <david.quintas@sentry.io>
Contributor
|
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft proposal for opt-in Cronet instrumentation, providing HTTP request visibility for apps using Cronet, including HTTP/3.
Adds
sentry-android-cronetwith an experimentalSentryCronetCallback. Applications wrap their callback and callcallback.start(request)to start anhttp.clientspan with the request. Success, failure, and cancellation finish the span and add an HTTP breadcrumb using existing Sentry URL filtering and HTTP data conventions. The delegate retains redirect and body-read control; negotiated protocol is recorded when Cronet supplies it.This deliberately does not replace the engine, inject tracing headers, capture bodies, create phase-level network spans, or emit failed-request error events. One span covers the original request through redirects. The README documents the explicit-start API and its limits.
The public API and provider compatibility need Android SDK team review. Before this can leave draft: run the repository Android checks, regenerate the API dump with the Android build, and validate against a real Cronet engine/device. Local repository Gradle execution is blocked by a dependency-download certificate error; the checked-in API snapshot was generated with the repository's binary-compatibility-validator version in an isolated JVM harness using an equivalent BuildConfig, not by hand.
Public integration docs, release-registry registration, and the
.craft.ymlSDK entry remain publishing follow-ups. No existing Cronet implementation or customer code was used.via david.quintas.
--
View Junior Session [Sentry]