Skip to content

ref(android): Remove Nav3 breadcrumb TypeCheckHint - #6201

Merged
0xadam-brown merged 1 commit into
mainfrom
ref/nav3-remove-breadcrumb-hint
Oct 2, 2026
Merged

0xadam-brown merged 1 commit into
mainfrom
ref/nav3-remove-breadcrumb-hint

Conversation

@0xadam-brown

@0xadam-brown 0xadam-brown commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

📜 Description

Removes our Nav3 TypeCheckHint for breadcrumbs, which was cargo-culted from Nav2. (The Nav2 use case is described here; it doesn't apply to Nav3 for the reasons given below.)

💡 Motivation and Context

Were we to keep the TypeCheckHint, developers would be able to access Nav3 breadcrumbs via the beforeBreadcrumb callback. But that's not needed because - unlike Nav2 - developers can scrub Nav3 data before it's recorded. Our public KDocs instruct them to do so for all Sentry Nav3 data, not just breadcrumbs.

Supporting a mechanism for after-the-fact access to just breadcrumb data (and not other Nav3 data) would be both asymmetrical and superfluous.

Note: I'm assuming there a policy that requires TypeCheckHints for breadcrumbs. That seems correct, as only some of our breadcrumb-producing integrations use TypeCheckHints and my clanker couldn't find any Sentry docs that indicate they're required.

addresses: JAVA-274

💚 How did you test it?

n/a

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

@0xadam-brown
0xadam-brown marked this pull request as ready for review October 1, 2026 07:19
@sentry

sentry Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.59.0 (1) release

⚙️ sentry-android Build Distribution Settings

@0xadam-brown 0xadam-brown added the sanity-check PR needs a lightweight review for obvious issues label Oct 1, 2026
Base automatically changed from ref/sentry-nav-effect-consolidate-extractors to main October 1, 2026 17:36
Commit removes our Nav3 TypeCheckHint for breadcrumbs, which was cargo-culted from Nav2. We don't need it because - unlike Nav2 - developers can scrub Nav3 data before it's recorded. Our public KDocs instruct them to do so for *all* Sentry Nav3 data, not just breadcrumbs.

Supporting a mechanism for after-the-fact access to just breadcrumb data (and not other Nav3 data) would be both asymmetrical and superfluous.
@0xadam-brown
0xadam-brown force-pushed the ref/nav3-remove-breadcrumb-hint branch from fb46c6b to 1354262 Compare October 2, 2026 05:56
@0xadam-brown

Copy link
Copy Markdown
Member Author

Rebased on an updated target; otherwise unchanged.

@0xadam-brown
0xadam-brown enabled auto-merge (squash) October 2, 2026 06:00
@0xadam-brown
0xadam-brown merged commit 65c166a into main Oct 2, 2026
74 checks passed
@0xadam-brown
0xadam-brown deleted the ref/nav3-remove-breadcrumb-hint branch October 2, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sanity-check PR needs a lightweight review for obvious issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants