ref(android): Remove Nav3 breadcrumb TypeCheckHint - #6201
Merged
Merged
Conversation
0xadam-brown
marked this pull request as ready for review
October 1, 2026 07:19
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 1, 2026 07:19
📲 Install BuildsAndroid
|
Base automatically changed from
ref/sentry-nav-effect-consolidate-extractors
to
main
October 1, 2026 17:36
Commit removes our Nav3 TypeCheckHint for breadcrumbs, which was cargo-culted from Nav2. We don't need it because - unlike Nav2 - developers can scrub Nav3 data before it's recorded. Our public KDocs instruct them to do so for *all* Sentry Nav3 data, not just breadcrumbs. Supporting a mechanism for after-the-fact access to just breadcrumb data (and not other Nav3 data) would be both asymmetrical and superfluous.
0xadam-brown
force-pushed
the
ref/nav3-remove-breadcrumb-hint
branch
from
October 2, 2026 05:56
fb46c6b to
1354262
Compare
Member
Author
|
Rebased on an updated target; otherwise unchanged. |
markushi
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removes our Nav3
TypeCheckHintfor breadcrumbs, which was cargo-culted from Nav2. (The Nav2 use case is described here; it doesn't apply to Nav3 for the reasons given below.)💡 Motivation and Context
Were we to keep the TypeCheckHint, developers would be able to access Nav3 breadcrumbs via the
beforeBreadcrumbcallback. But that's not needed because - unlike Nav2 - developers can scrub Nav3 data before it's recorded. Our public KDocs instruct them to do so for all Sentry Nav3 data, not just breadcrumbs.Supporting a mechanism for after-the-fact access to just breadcrumb data (and not other Nav3 data) would be both asymmetrical and superfluous.
Note: I'm assuming there a policy that requires TypeCheckHints for breadcrumbs. That seems correct, as only some of our breadcrumb-producing integrations use TypeCheckHints and my clanker couldn't find any Sentry docs that indicate they're required.
addresses: JAVA-274
💚 How did you test it?
n/a
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps