Conversation
Contributor
|
📲 Install BuildsAndroid
|
This was referenced Oct 2, 2026
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
force-pushed
the
danf/spring-checkin-scheduled-config
branch
from
October 5, 2026 22:54
ff1e1e2 to
5d745c7
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
marked this pull request as ready for review
October 5, 2026 23:28
wedamija
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
October 5, 2026 23:28
Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f5ad4e. Configure here.
Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Stacked on #6217 (core
MonitorConfigUtils).📜 Description
For
@SentryCheckInmethods, the check-in advice now reads the schedule from the method's@Scheduledannotation and sends it as a monitor config with the check-in, so Sentry creates the monitor, or updates its schedule, from code. This is on by default;@SentryCheckIn(upsertMonitorConfig = false)turns it off.Cron schedules (with their zone) and fixed-rate intervals are supported. When a schedule can't be represented exactly, such as a fixed delay whose runs drift, the check-in is sent without a config, as today, rather than with a schedule that would cause false missed-check-in alerts. Settings managed in Sentry (margins, max runtime, thresholds) are kept.
The same change is made in
sentry-spring,sentry-spring-jakartaandsentry-spring-7; only the packages differ.💡 Motivation and Context
Check-ins for a monitor that doesn't exist yet are dropped, so today every
@SentryCheckInmonitor has to be created by hand in Sentry, with its schedule copied from@Scheduled. The schedule is already in the code, so the SDK can send it, and monitors are created and kept in sync automatically.This is on by default even though new features are usually opt-in:
@SentryCheckInis already an explicit opt-in to monitoring, and today those check-ins are dropped until the monitor is created by hand. On upgrade, existing monitors get their schedule and timezone from@Scheduled(the JVM zone whenzoneisn't set);upsertMonitorConfig = falsekeeps managing them in Sentry.💚 How did you test it?
SentryCheckInAdviceTestin each Spring module. The schedule conversion is tested in #6217.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Docs: getsentry/sentry-docs#19780