Repository navigation
Conversation
Keep the feedback form usable when an options configuration callback throws. Apply callback changes transactionally so partially mutated feedback options are discarded. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
…ndling-user-feedback
Ensure a failed legacy configuration does not prevent the configurator from receiving the original feedback options and applying its changes. Co-Authored-By: Claude <noreply@anthropic.com>
Ensure fatal errors from the feedback options configurator are rethrown instead of being handled as recoverable callback failures. Co-Authored-By: Claude <noreply@anthropic.com>
…ndling-user-feedback
adinauer
marked this pull request as ready for review
October 13, 2026 08:11
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
October 13, 2026 08:11
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Fixes
- Handle feedback configurator failures ([#6239](https://github.com/getsentry/sentry-java/pull/6239))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Handle exceptions from Android feedback
OptionsConfigurationandOptionsConfiguratorcallbacks without preventing the feedback form from opening. Each callback receives a copy of the current options, and its mutations are committed only when it completes successfully.💡 Motivation and Context
A customer callback could currently crash feedback form construction. It could also leave partially applied option changes before throwing. Falling back to the last valid options keeps the form available and avoids exposing partially configured state.
💚 How did you test it?
./gradlew spotlessApply apiDump./gradlew :sentry-android-core:testReleaseUnitTest --tests io.sentry.android.core.SentryUserFeedbackFormTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.