Repository navigation
test(spring): [Sample Tests 29] Move the Spring WAR sample's tests into the module - #6321
Draft
runningcode wants to merge 1 commit into
Draft
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
Draft
📲 Install BuildsAndroid
|
4 of 9 tasks
This was referenced Oct 20, 2026
Draft
Draft
Draft
Draft
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 21, 2026 09:19
cd8325f to
d5e9509
Compare
runningcode
force-pushed
the
no/spring-integration-test
branch
from
October 21, 2026 09:19
e40433c to
c037b50
Compare
Adds sentry-spring-jakarta's embedded-Tomcat integrationTest suite to sentry-spring, with the module's packages and javax.servlet. The sample's tests were the jakarta WAR sample's, so the suite is too. Spring Boot 2's BOM picks Spring 5.3 and Tomcat 9. The sample has no system tests left, so it comes off the system-test runner, the backend workflow and the Spring Boot 2 matrix. That was the matrix's last runner step, so it drops the Python setup, the runner's logs and the exclude properties only the samples and the runner read. integrationTests includes the suite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/spring-7-integration-test
branch
from
October 21, 2026 11:27
d5e9509 to
c5ff6d9
Compare
runningcode
force-pushed
the
no/spring-integration-test
branch
from
October 21, 2026 11:27
c037b50 to
334a404
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Sample Tests)
main)📜 Description
Adds #6319's embedded-Tomcat
integrationTestsuite tosentry-spring, withio.sentry.spring's packages andjavax.servlet.sentry-samples-spring's tests match the jakarta WAR sample's except for the URL, so the suite does too:http.servertransaction and the logs;Spring Boot 2's BOM picks Spring 5.3 and Tomcat 9. As in #6319, Spring Boot itself stays off the suite's classpath, so Sentry's servlet container initializer takes its WAR path and adds
SentrySpringFilter.With no system tests left, the sample comes off the runner, the backend workflow and the Spring Boot 2 matrix. That was the matrix's last runner step, so the matrix also drops:
SENTRY_URL;excludeGraphql/excludeKafkaexports, which only the sample builds and the runner read.integrationTestsincludes the suite.All three Spring Boot matrices now run only Gradle suites, and the WAR flavor is done.
💡 Motivation and Context
Plain Spring 5, without Boot, now runs end to end in the module. The suite runs 5 tests in a few seconds.
💚 How did you test it?
:sentry-spring:checkpasses, including animal sniffer, and the sample's WAR still builds.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The console samples: log4j2 and JUL into their modules, then the plain console sample.
#skip-changelog
🤖 Generated with Claude Code