fix(core): Account for clock drift in initial timestampInSeconds() call#22488
Draft
Lms24 wants to merge 2 commits into
Draft
fix(core): Account for clock drift in initial timestampInSeconds() call#22488Lms24 wants to merge 2 commits into
timestampInSeconds() call#22488Lms24 wants to merge 2 commits into
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22375 reports a valid bug which is that
timestampInSeconds()may return an inaccurate time stamp, since we don't detect clock drift between theperformance.timeOrigin + performance.now()timestamp andDate.now().This PR intentionally only partially fixes this problem by adding a clock drift check only to the initial
timestampInSecondscall. This should account for cases where the monotonicperformance.now()clock is already off at SDK init time but won't catch clock drift later on.From here we have two options:
timestampInSecondscall until then.Date.now(). This should give us more accurate timing overall but:PerformanceEntryentries, which include relative timestamps that might have also suffered from clock drift.I also still need to look at the
sent_atheader which should prompt Relay to perform clock-drift normalization but I'm not yet sure to which extent.Keeping this draft as a possible mitigation open for now