feat(vue): Register Vue route provider by logaretm · Pull Request #23793 · getsentry/sentry-javascript

logaretm · 2026-08-31T19:46:53Z

Registers a route provider for Vue, read off the Vue app the SDK is already given.

vue-router sets app.config.globalProperties.$router when it installs, so the provider needs no new option and no router passed to the tracing integration. That means it works for users who never pass router to browserTracingIntegration, and route parameterization no longer depends on tracing being enabled.

The router is looked up per call rather than captured at registration, because app.use(router) may legitimately run either side of Sentry.init().

Returns the matched path rather than route.name, even under routeLabel: 'name'. Callers set url.template from this and a route name is an identifier, not a template. The navigation instrumentation still names the span after the route name when the user asked for it.

Part of #23556

github-actions · 2026-08-31T19:54:19Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	29.51 kB	+0.51%	+148 B 🔺
@sentry/browser - with treeshaking flags	27.68 kB	+0.13%	+34 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing	27.58 kB	+0.14%	+38 B 🔺
@sentry/browser (incl. Tracing)	51.46 kB	+0.31%	+154 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)	51.47 kB	+0.3%	+149 B 🔺
@sentry/browser (incl. Tracing, Profiling)	54.47 kB	+0.31%	+164 B 🔺
@sentry/browser (incl. Tracing, Replay)	91.05 kB	+0.18%	+155 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	80.03 kB	+0.05%	+36 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	95.73 kB	+0.16%	+150 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	108.72 kB	+0.14%	+149 B 🔺
@sentry/browser (incl. Feedback)	47.04 kB	+0.33%	+154 B 🔺
@sentry/browser (incl. sendFeedback)	34.57 kB	+0.42%	+144 B 🔺
@sentry/browser (incl. FeedbackAsync)	39.69 kB	+0.37%	+143 B 🔺
@sentry/browser (incl. Metrics)	30.53 kB	+0.51%	+153 B 🔺
@sentry/browser (incl. Logs)	30.82 kB	+0.5%	+152 B 🔺
@sentry/browser (incl. Metrics & Logs)	31.48 kB	+0.47%	+147 B 🔺
@sentry/react	31.36 kB	+0.53%	+165 B 🔺
@sentry/react (incl. Tracing)	53.82 kB	+0.29%	+153 B 🔺
@sentry/vue	37.51 kB	+1.65%	+607 B 🔺
@sentry/vue (incl. Tracing)	54.36 kB	+0.89%	+476 B 🔺
@sentry/svelte	29.54 kB	+0.5%	+146 B 🔺
CDN Bundle	31.22 kB	+0.13%	+39 B 🔺
CDN Bundle (incl. Tracing)	51.99 kB	+0.08%	+41 B 🔺
CDN Bundle (incl. Logs, Metrics)	33.46 kB	+0.1%	+31 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	53.94 kB	+0.1%	+49 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	74.2 kB	+0.07%	+49 B 🔺
CDN Bundle (incl. Tracing, Replay)	89.56 kB	+0.04%	+34 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	91.54 kB	+0.05%	+45 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	95.73 kB	+0.04%	+33 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	97.73 kB	+0.07%	+60 B 🔺
CDN Bundle - uncompressed	92.14 kB	+0.11%	+95 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	154.53 kB	+0.07%	+95 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	98.71 kB	+0.1%	+95 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	160.48 kB	+0.06%	+95 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	228.28 kB	+0.05%	+95 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	274.26 kB	+0.04%	+95 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	280.2 kB	+0.04%	+95 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	287.96 kB	+0.04%	+95 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	293.89 kB	+0.04%	+95 B 🔺
@sentry/nextjs (client)	56.32 kB	+0.74%	+413 B 🔺
@sentry/sveltekit (client)	51.88 kB	+0.29%	+145 B 🔺
@sentry/core/server	39.99 kB	-	-
@sentry/core/browser	13.63 kB	-	-
@sentry/node	144.03 kB	+0.01%	+8 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)	82.98 kB	-	-
@sentry/node - without tracing	92.91 kB	+0.01%	+9 B 🔺
@sentry/node - without channel injection	122.41 kB	+0.01%	+9 B 🔺
@sentry/aws-serverless	101.17 kB	-0.01%	-9 B 🔽
@sentry/cloudflare (withSentry) - minified	206.69 kB	-	-
@sentry/cloudflare (withSentry)	514.13 kB	-	-

View base workflow run

github-actions · 2026-09-22T14:01:02Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you apply the label PR: no-auto-close I will leave it alone ... forever!

logaretm · 2026-09-24T20:44:11Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

s1gr1d · 2026-09-25T11:26:52Z

    defaultIntegrations: [...getDefaultIntegrations(options), vueIntegration()],
+    // The router is read off the app on each call, so `app.use(router)` can run either side of `init`, and
+    // users who never pass `router` to the tracing integration still get parameterized routes.
+    ...(options.app && { routeProvider: createVueRouteProvider(() => getRouterFromApp(options.app)) }),


In Vue 2, this would be options.App (make sure to also test Vue 2 E2E)

do we have a Vue 2 E2E? should I add one?

github-actions · 2026-09-29T10:17:38Z

👋 @chargome, @nicohrubec — Please review this PR when you get a chance!

cursor

Stale Bugbot comment from a previous run.

`vue-router` sets `app.config.globalProperties.$router` when it installs, and the SDK is already given the app, so the provider needs no new option and no router passed to the tracing integration. Registered from `init()`, so route parameterization no longer depends on tracing being enabled and works for users who never pass `router` to `browserTracingIntegration`. The router is looked up per call rather than captured, because `app.use(router)` may run either side of `Sentry.init()`. Returns the matched path rather than `route.name` even under `routeLabel: 'name'`: callers set `url.template` from this and a route name is an identifier, not a template. The navigation instrumentation still names the span after the route name when the user asked for it.

…ueIntegration`

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 89d893e. Configure here.}

cursor · 2026-09-30T17:19:37Z

+      // The router is looked up lazily because it may be installed after `init`. A user's `routeProvider` wins.
+      if (!getRouteProvider(client)) {
+        const { app, Vue } = options;
+        const getRouter = app ? () => getRouterFromApp(app) : captureRouterFromVue(Vue!);


Non-null assertion lacks required comment

Low Severity

A new non-null assertion on Vue has no comment explaining why a safer type is not possible. The earlier app/Vue guard makes the assertion valid, but the project rule still requires that comment on new ! uses in SDK source. Flagged because this was mentioned in the review rules file.

^{Triggered by project rule: PR Review Guidelines for Cursor Bot}

^{Reviewed by Cursor Bugbot for commit 89d893e. Configure here.}

github-actions Bot added the PR: stale label Sep 22, 2026

logaretm added the PR: no-auto-close label Sep 22, 2026

logaretm force-pushed the awad/route-provider-vue-app branch from a1394dd to ece4da5 Compare September 24, 2026 18:04

logaretm force-pushed the awad/route-provider-vue-app branch from ece4da5 to a309ce7 Compare September 24, 2026 18:14

logaretm force-pushed the awad/route-provider-vue-app branch from a309ce7 to 3dbcc53 Compare September 24, 2026 18:30

logaretm force-pushed the awad/route-provider-vue-app branch from 3dbcc53 to 227053e Compare September 24, 2026 18:50

logaretm force-pushed the awad/route-provider-vue-app branch 2 times, most recently from 22d7992 to e741e61 Compare September 24, 2026 19:59

logaretm changed the title ~~feat(vue): Register a route provider read off the Vue app~~ feat(vue): Register Vue route provider Sep 24, 2026

cursor Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread packages/vue/src/routeProvider.ts

Comment thread packages/vue/test/routeProvider.test.ts

logaretm force-pushed the awad/route-provider-vue-app branch from e741e61 to b344925 Compare September 24, 2026 21:20

logaretm marked this pull request as ready for review September 24, 2026 21:26

logaretm requested a review from a team as a code owner September 24, 2026 21:26

logaretm requested review from chargome, nicohrubec and s1gr1d and removed request for a team September 24, 2026 21:26

s1gr1d reviewed Sep 25, 2026

View reviewed changes

logaretm removed the PR: stale label Sep 25, 2026

logaretm force-pushed the awad/route-provider-vue-app branch from b344925 to fa6bf94 Compare September 28, 2026 22:08

logaretm force-pushed the awad/route-provider-vue-app branch from fa6bf94 to 57914a9 Compare September 29, 2026 19:34

cursor Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread packages/vue/src/sdk.ts Outdated

logaretm force-pushed the awad/route-provider-vue-app branch from 57914a9 to 63d9a6f Compare September 30, 2026 16:49

logaretm force-pushed the awad/route-provider-vue-app branch from 63d9a6f to 8a6336a Compare September 30, 2026 16:52

logaretm force-pushed the awad/route-provider-vue-app branch from 8a6336a to 3f219dc Compare September 30, 2026 17:00

logaretm added 5 commits September 30, 2026 19:02

ref(vue): Import the route provider API from @sentry/core/browser

8d0bdc4

ref(vue): Import the route provider API from @sentry/browser

2356402

ref(vue): Pass the route provider as the routeProvider option

20cff46

test(vue): Cover route resolution through the route provider

0b03209

logaretm force-pushed the awad/route-provider-vue-app branch from 3f219dc to 0b03209 Compare September 30, 2026 17:02

logaretm added 2 commits September 30, 2026 19:08

fix(vue): Resolve hash and base routes, register the provider from `v…

a6c8975

…ueIntegration`

feat(vue): Register the route provider for Vue 2

89d893e

cursor Bot reviewed Sep 30, 2026

View reviewed changes

Uh oh!

Conversation

logaretm commented Aug 31, 2026

Uh oh!

github-actions Bot commented Aug 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

logaretm commented Sep 24, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

s1gr1d Sep 25, 2026

Choose a reason for hiding this comment

Uh oh!

logaretm Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Sep 30, 2026

Choose a reason for hiding this comment

Non-null assertion lacks required comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Aug 31, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading