Conversation
…g binding Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
rytkhs
marked this pull request as ready for review
September 22, 2026 14:01
rytkhs
requested review from
isaacs and
mydea
and removed request for
a team
September 22, 2026 14:01
Author
|
Closing in favor of #24592, which has the same fix plus a workerd integration test. Thanks for the quick turnaround! |
Member
|
Sorry haven't seen this one - I'll mention you on our contributors list. Thanks a lot though for opening up a PR |
JPeer264
added a commit
that referenced
this pull request
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentQueueProducerwrapssendandsendBatchand returns every other property from the Proxy unbound. Calling a native method it doesn't wrap, likeQueue#metrics(), then runs it with the Proxy asthis, and workerd throwsIllegal invocation. Passed-through functions are now bound to the binding, as the Durable Object namespace/storage and Workers AI proxies already do.Fixes #24590