Skip to content

fix(bun): Keep diagnostics channel subscriptions alive - #24632

Open
JPeer264 wants to merge 1 commit into
jp/node-suites-denofrom
jp/node-suites-bun-sdk-fixes
Open

fix(bun): Keep diagnostics channel subscriptions alive#24632
JPeer264 wants to merge 1 commit into
jp/node-suites-denofrom
jp/node-suites-bun-sdk-fixes

Conversation

@JPeer264

@JPeer264 JPeer264 commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Bun garbage-collects a diagnostics channel that no code references, and its subscribers with it. Node and Deno keep subscribed channels alive. The channel integrations kept no reference, so on Bun they could silently stop producing spans after the first GC. They now create their channels through wrappers in @sentry/server-utils that keep one.

@sentry/bun uses these integrations, and also httpIntegration from @sentry/node, whose channel subscriptions now go through the same wrappers. diagnosticsChannelGc.test.ts reproduces the GC on Bun.

Running the shared Node integration suites on Bun found this.

Part of #23889.

🤖 Generated with Claude Code

@linear-code

linear-code Bot commented Sep 23, 2026

Copy link
Copy Markdown

JS-3515

@JPeer264
JPeer264 added this pull request to stack #24633 September 23, 2026 09:51
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch 2 times, most recently from 33f7607 to 77ca363 Compare September 23, 2026 10:04
@github-actions

github-actions Bot commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.24 kB - -
@sentry/browser - with treeshaking flags 27.5 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.4 kB - -
@sentry/browser (incl. Tracing) 51.15 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.17 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.18 kB - -
@sentry/browser (incl. Tracing, Replay) 90.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.46 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.41 kB - -
@sentry/browser (incl. Feedback) 46.76 kB - -
@sentry/browser (incl. sendFeedback) 34.3 kB - -
@sentry/browser (incl. FeedbackAsync) 39.41 kB - -
@sentry/browser (incl. Metrics) 30.25 kB - -
@sentry/browser (incl. Logs) 30.51 kB - -
@sentry/browser (incl. Metrics & Logs) 31.18 kB - -
@sentry/react 31 kB - -
@sentry/react (incl. Tracing) 53.45 kB - -
@sentry/vue 36.74 kB - -
@sentry/vue (incl. Tracing) 53.7 kB - -
@sentry/svelte 29.26 kB - -
CDN Bundle 30.93 kB - -
CDN Bundle (incl. Tracing) 51.69 kB - -
CDN Bundle (incl. Logs, Metrics) 33.2 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.66 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.92 kB - -
CDN Bundle (incl. Tracing, Replay) 89.28 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.25 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.45 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.42 kB - -
CDN Bundle - uncompressed 91.4 kB - -
CDN Bundle (incl. Tracing) - uncompressed 153.77 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.97 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 159.73 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.54 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 273.5 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 279.44 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.13 kB - -
@sentry/nextjs (client) 55.77 kB - -
@sentry/sveltekit (client) 51.59 kB - -
@sentry/core/server 39.95 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 136.77 kB +0.11% +137 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.74 kB +0.22% +178 B 🔺
@sentry/node - without tracing 90.78 kB +0.23% +207 B 🔺
@sentry/node - without channel injection 115.14 kB +0.05% +52 B 🔺
@sentry/aws-serverless 99.04 kB +0.2% +196 B 🔺
@sentry/cloudflare (withSentry) - minified 206.49 kB - -
@sentry/cloudflare (withSentry) 513.73 kB - -

View base workflow run

@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 77ca363 to 72e8bec Compare September 23, 2026 12:21
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 72e8bec to 373d5ab Compare September 23, 2026 12:24
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 373d5ab to 49333f3 Compare September 23, 2026 13:23
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch 2 times, most recently from 7452887 to 27c4421 Compare September 23, 2026 16:19
@JPeer264
JPeer264 removed this pull request from stack #24633 September 23, 2026 16:19
@JPeer264
JPeer264 added this pull request to stack #24670 September 23, 2026 16:19
@JPeer264 JPeer264 changed the title fix(bun, node): Fix channel GC, http.server spans and fetch spans on Bun fix(bun, node): Keep diagnostics channels alive and create http.server spans on Bun Sep 23, 2026
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 27c4421 to ff5d855 Compare September 23, 2026 16:40
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch 2 times, most recently from b0e5f06 to 21f68ca Compare September 23, 2026 16:59
@JPeer264
JPeer264 removed this pull request from stack #24670 September 23, 2026 17:26
@JPeer264 JPeer264 changed the title fix(bun, node): Keep diagnostics channels alive and create http.server spans on Bun fix(bun): Keep diagnostics channel subscriptions alive Sep 23, 2026
@JPeer264
JPeer264 added this pull request to stack #24671 September 23, 2026 17:31
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 763a9ee to 0b4a065 Compare September 24, 2026 09:13
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch 2 times, most recently from b3a3cf2 to ef10728 Compare September 24, 2026 14:05
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch 3 times, most recently from 2cd8f16 to 7fae1f6 Compare September 25, 2026 15:41
@JPeer264
fix(bun): Keep diagnostics channel subscriptions alive
2882826 
Bun garbage-collects a diagnostics channel that no code references, together
with its subscribers, so a subscription made at init() could stop receiving
messages after the next GC. Node and Deno keep a subscribed channel alive.
On Bun, the channel wrappers in @sentry/server-utils now keep a reference to
every channel they return, and the channel integrations and httpIntegration
use them. Other runtimes get the original node:diagnostics_channel functions.

graphql-tracing-channel, which the GC broke, now runs on Bun.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/node-suites-bun-sdk-fixes branch from 7fae1f6 to 2882826 Compare September 25, 2026 15:49
@JPeer264 JPeer264 self-assigned this Sep 25, 2026
@JPeer264
JPeer264 marked this pull request as ready for review September 25, 2026 15:55
@JPeer264
JPeer264 requested a review from a team as a code owner September 25, 2026 15:55
@JPeer264
JPeer264 requested review from andreiborza, isaacs and mydea and removed request for a team September 25, 2026 15:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@andreiborza andreiborza Awaiting requested review from andreiborza

At least 1 approving review is required to merge this pull request.

Assignees

@JPeer264 JPeer264

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JPeer264