feat(server-utils): Add TypeSafe integration - #24703
Draft
andreiborza wants to merge 2 commits into
Draft
andreiborza wants to merge 2 commits into
andreiborza wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
changed the title
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59126fd. Configure here.
| expect(span.attributes[GEN_AI_INPUT_MESSAGES]).toBeUndefined(); | ||
| expect(span.attributes[GEN_AI_OUTPUT_MESSAGES]).toBeUndefined(); | ||
| // State, questions and answers must not come back through another attribute (e.g. an error message). | ||
| expect(JSON.stringify(span)).not.toMatch(/cannot log in|Charges and refunds|0\.98/); |
There was a problem hiding this comment.
Flaky privacy regex matches timestamps
Medium Severity
The privacy assertion stringifies each span and forbids the substring 0.98. Streamed spans include fractional Unix start_timestamp and end_timestamp values, so a time whose decimal part contains 0.98 fails even when no evaluation data leaked. Flagged because the review rules call out flake-prone tests.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 59126fd. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Calls to TypeSafe's Jev through
@typesafe-ai/sdk(TypeSafeClient.systemOne) now create agen_ai.evaluatespan with the same shape as the Vercel AI evaluate span.instrumentTypeSafeClient()does the same for runtimes without auto-instrumentation.Why
Users who call Jev directly got only a plain
http.clientspan.Closes: #24693