Conversation
…rding is disabled The 'genAI recording disabled' integration tests for Anthropic, LangChain, and Google GenAI only asserted non-PII attributes. Add explicit assertions that content-bearing attributes (input messages, system instructions, response text/tool calls, tool definitions, embeddings input) are undefined on every span, so a regression in the recording gate fails loudly. Fixes #19801 Co-Authored-By: Muse Spark <noreply@meta.com>
Lms24
previously approved these changes
Sep 28, 2026
Lms24
dismissed
their stale review
September 28, 2026 10:38
Still in draft. Dismissing until ready for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'genAI recording disabled' integration tests for Anthropic, LangChain, and Google GenAI asserted non-PII attributes but never explicitly checked that content-bearing attributes stay absent. This adds explicit
toBeUndefinedassertions for input messages, system instructions, response text/tool calls, tool definitions, and embeddings input on every span in those disabled scenarios, so a regression in the recording gate fails loudly instead of silently leaking PII into span data.Verified locally: all 73 tests across the three suites pass (
suites/tracing/anthropic,suites/tracing/langchain,suites/tracing/google-genai); oxlint and oxfmt clean.Fixes #19801