chore(solidstart): Remove unused Vitest setup from e2e apps - #24789
Merged
Merged
Conversation
Lms24
added this pull request to stack #24790
September 28, 2026 09:56
Lms24
marked this pull request as ready for review
September 28, 2026 12:31
andreiborza
approved these changes
Sep 28, 2026
Lms24
requested review from
JPeer264,
isaacs,
logaretm,
msonnb and
nicohrubec
and removed request for
a team
September 29, 2026 15:58
Lms24
force-pushed
the
chore/remove-solidstart-vitest
branch
from
September 29, 2026 15:58
7f660ef to
4fce78d
Compare
The SolidStart e2e apps only run Playwright. `vitest`, `@vitest/ui` and `vitest.config.ts` were leftovers from the Solid CLI template and kept old Vitest versions around in the repo. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
chore/remove-solidstart-vitest
branch
from
September 29, 2026 16:23
4fce78d to
6922e24
Compare
Contributor
size-limit report 📦
|
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SolidStart e2e apps only run Playwright, so
vitest,@vitest/uiandvitest.config.tsare unused leftovers from the Solid CLI template. Noticed while working on #24746. Didn't cause a direct dependency duplication but thought it would be good to get this cleaned up.