Conversation
Patches `createRouter` through orchestrion to prepend a Sentry middleware to every router. The middleware opens no span: Remix 3 serves over `node:http`, so `httpIntegration` has already opened the `http.server` span. It only enriches it with the route, the response status and a low cardinality name. The matcher has to be supplied by the SDK because the router never exposes one, and the request context carries no pattern at middleware entry. Matching happens after router middleware runs and only writes back `params`, so the route is resolved by re-running the match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ae0ee84. Configure here.
Contributor
size-limit report 📦
|
chargome
added this pull request to stack #24803
September 28, 2026 16:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches
createRouterthrough orchestrion to prepend a Sentry middleware to every router. The middleware opens no span: Remix 3 serves overnode:http, sohttpIntegrationhas already opened thehttp.serverspan. It only enriches that span withhttp.route, the response status and a low cardinality name.The SDK supplies the router's matcher, because the router never exposes one and the request context carries no pattern at middleware entry. The route is resolved by re-running the match against that matcher.
Remix 3 has no build step, so no bundler plugin can apply the transform. The
--import @sentry/remix/v3/nodeentry registers the module hook and subscribes before the app's own modules are imported, and replaces--import remix/node-tsxrather than adding a second flag.Error handling is a separate pull request.