fix(node): Flush buffered metrics on process exit - #24806
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 29a93e1. Configure here.
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
September 28, 2026 17:33
nicohrubec
requested review from
JPeer264 and
isaacs
and removed request for
a team
September 28, 2026 17:33
logaretm
approved these changes
Sep 28, 2026
nicohrubec
added a commit
that referenced
this pull request
Sep 29, 2026
Add the missing metrics exit on flush in Deno similar to #24806. --------- Co-authored-by: GPT-6 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing
beforeExitflush for metrics, matching the existing behavior for logs and client reports. This ensures buffered metrics are sent when a Node process exits naturally, even if the timer or size threshold has not triggered a flush yet.