perf(server-utils): Avoid quadratic SQL sanitizer output handling - #24834
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
Contributor
size-limit report 📦
|
…ndaries Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
September 29, 2026 19:11
nicohrubec
requested review from
JPeer264,
Lms24 and
isaacs
and removed request for
a team
September 29, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large SQL statements with many quoted literals can block the event loop, because the prefix checks in
getLiteralPrefixcause repeated flattening of the result string buffer (resulting in a full copy of the result string up to that point). This is very costly and can be easily avoided by instead pushing the sanitized bits to an array and joining once at the end.Local benchmark comparing the approaches:
Closes #24812