fix(effect)!: Change peerDependency to v4 and fix currentSpan - #24940
Merged
Merged
Conversation
JPeer264
requested review from
chargome and
nicohrubec
and removed request for
a team
October 1, 2026 11:58
nicohrubec
approved these changes
Oct 1, 2026
JPeer264
enabled auto-merge (squash)
October 1, 2026 12:09
JPeer264
disabled auto-merge
October 1, 2026 12:53
JPeer264
changed the title
JPeer264
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating tests to Effect v4 and our dev dependencies of the SDK. The
peerDependencywas updated to v4 stable as the fiber changed. We would have needed a workaround to also support beta and rc versions, which is IMO not worth it just for supporting a betaBreaking because we had to change where the
currentSpanis coming from. With that we don't support beta versions anymore