Skip to content

fix(replay): Apply attribute masking to breadcrumb messages - #25180

Open
msonnb wants to merge 6 commits into
developfrom
ms/replay-breadcrumb-attribute-masking
Open

msonnb wants to merge 6 commits into
developfrom
ms/replay-breadcrumb-attribute-masking

Conversation

@msonnb

@msonnb msonnb commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Replay's configured attribute masking covered DOM snapshots, but click and keyboard breadcrumb messages could still contain raw values. Apply the same masking rules to those messages, including ancestor attributes, so defaults and custom masks stay consistent while preserving explicit unmasking.

Completes the breadcrumb handling missed by #16192. Browser integration expectations now assert masked attribute values.

Fixes JS-3832.

Co-Authored-By: GPT-6 <codex@openai.com>
@linear-code

linear-code Bot commented Oct 8, 2026

Copy link
Copy Markdown

JS-3832

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.9 kB +0.24% +70 B 🔺
@sentry/browser - with treeshaking flags 28.04 kB +0.26% +71 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 27.95 kB +0.26% +70 B 🔺
@sentry/browser (incl. Tracing) 51.98 kB +0.16% +82 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 51.99 kB +0.16% +78 B 🔺
@sentry/browser (incl. Tracing, Profiling) 54.93 kB +0.15% +80 B 🔺
@sentry/browser (incl. Tracing, Replay) 91.76 kB +0.13% +116 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.64 kB +0.15% +118 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 96.5 kB +0.14% +132 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 109.46 kB +0.11% +118 B 🔺
@sentry/browser (incl. Feedback) 47.43 kB +0.15% +71 B 🔺
@sentry/browser (incl. sendFeedback) 34.95 kB +0.21% +73 B 🔺
@sentry/browser (incl. FeedbackAsync) 40.06 kB +0.18% +70 B 🔺
@sentry/browser (incl. Metrics) 30.93 kB +0.24% +71 B 🔺
@sentry/browser (incl. Logs) 31.22 kB +0.23% +71 B 🔺
@sentry/browser (incl. Metrics & Logs) 31.88 kB +0.3% +94 B 🔺
@sentry/react 31.75 kB +0.23% +71 B 🔺
@sentry/react (incl. Tracing) 54.3 kB +0.15% +76 B 🔺
@sentry/vue 37.97 kB +0.2% +73 B 🔺
@sentry/vue (incl. Tracing) 54.91 kB +0.15% +77 B 🔺
@sentry/svelte 29.93 kB +0.24% +71 B 🔺
@sentry/remix (Remix 3 client bundle) 56.96 kB +0.13% +72 B 🔺
CDN Bundle 31.65 kB +0.23% +72 B 🔺
CDN Bundle (incl. Tracing) 52.48 kB +0.14% +72 B 🔺
CDN Bundle (incl. Logs, Metrics) 33.84 kB +0.2% +67 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 54.44 kB +0.15% +81 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.81 kB +0.17% +120 B 🔺
CDN Bundle (incl. Tracing, Replay) 90.18 kB +0.12% +105 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.12 kB +0.12% +106 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 96.34 kB +0.12% +106 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.31 kB +0.11% +107 B 🔺
CDN Bundle - uncompressed 93.28 kB +0.22% +200 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 155.86 kB +0.13% +200 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.82 kB +0.21% +200 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 161.82 kB +0.13% +200 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 230 kB +0.15% +342 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 276.17 kB +0.13% +342 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.11 kB +0.13% +342 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 289.88 kB +0.12% +342 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.8 kB +0.12% +342 B 🔺
@sentry/nextjs (client) 56.67 kB +0.13% +73 B 🔺
@sentry/sveltekit (client) 52.35 kB +0.15% +74 B 🔺
@sentry/core/server 40.87 kB - -
@sentry/core/browser 13.73 kB - -
@sentry/node 151.69 kB +0.01% +3 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.77 kB - -
@sentry/node - without tracing 94.26 kB +0.01% +9 B 🔺
@sentry/node - without channel injection 129.87 kB +0.01% +8 B 🔺
@sentry/aws-serverless 102.43 kB +0.01% +2 B 🔺
@sentry/cloudflare (withSentry) - minified 210.03 kB - -
@sentry/cloudflare (withSentry) 520.73 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 227.7 kB - -

View base workflow run

msonnb and others added 5 commits October 8, 2026 15:05
Co-Authored-By: GPT-6 <codex@openai.com>
Leave size-limit adjustments for a separate change.

Co-Authored-By: GPT-6 <codex@openai.com>
@msonnb

msonnb commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f768c01. Configure here.

@msonnb
msonnb marked this pull request as ready for review October 9, 2026 12:02
@msonnb
msonnb requested a review from a team as a code owner October 9, 2026 12:02
@msonnb
msonnb requested review from Lms24 and logaretm and removed request for a team October 9, 2026 12:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant