Skip to content

test(node): Port fetch request suites to span streaming #25189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 4 commits into from
Oct 9, 2026
+25 −11
Merged

test(node): Port fetch request suites to span streaming #25189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bec19f5
test(node): Port fetch request suites to span streaming
nicohrubec Oct 8, 2026
7b23fe0
test(node): Ignore fetch spans in propagation header test
nicohrubec Oct 8, 2026
e1afadd
test(node): Assert all parentless fetch request spans
nicohrubec Oct 9, 2026
954e811
Merge branch 'develop' into feat/fetch-request-tests-span-streaming
nicohrubec Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/fetch-breadcrumbs/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion .../node-integration-tests/suites/tracing/requests/fetch-no-trace-propagation/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
integrations: [Sentry.nativeNodeFetchIntegration({ tracePropagation: false })],
Expand Down
1 change: 0 additions & 1 deletion ...s/node-integration-tests/suites/tracing/requests/fetch-no-tracing-no-spans/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/fetch-no-tracing/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
1 change: 0 additions & 1 deletion ...ode-integration-tests/suites/tracing/requests/fetch-sampled-no-active-span/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
30 changes: 25 additions & 5 deletions ...kages/node-integration-tests/suites/tracing/requests/fetch-sampled-no-active-span/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,24 @@
import { SENTRY_OP, URL_FULL } from '@sentry/conventions/attributes';
import { HTTP_CLIENT } from '@sentry/conventions/op';
import { createTestServer } from '@sentry-internal/test-utils';
import { describe, expect } from 'vitest';
import { createEsmAndCjsTests } from '../../../../utils/runner';

describe('outgoing fetch', () => {
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createRunner, test) => {
test('outgoing sampled fetch requests without active span are correctly instrumented', async () => {
expect.assertions(11);
expect.assertions(21);

const [SERVER_URL, closeTestServer] = await createTestServer()
.get('/api/v0', headers => {
expect(headers['baggage']).toEqual(expect.any(String));
expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-0$/));
expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-0');
expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-1$/));
expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-1');

@nicohrubec nicohrubec Oct 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes because for span streaming parentless fetch spans get sampled

})
.get('/api/v1', headers => {
expect(headers['baggage']).toEqual(expect.any(String));
expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-0$/));
expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-0');
expect(headers['sentry-trace']).toEqual(expect.stringMatching(/^([a-f\d]{32})-([a-f\d]{16})-1$/));
expect(headers['sentry-trace']).not.toEqual('00000000000000000000000000000000-0000000000000000-1');
Comment thread
cursor[bot] marked this conversation as resolved.
})
.get('/api/v2', headers => {
expect(headers['baggage']).toBeUndefined();
Expand All @@ -30,6 +32,7 @@ describe('outgoing fetch', () => {

await createRunner()
.withEnv({ SERVER_URL })
.unordered()
.expect({
event: {
exception: {
Expand All @@ -42,6 +45,23 @@ describe('outgoing fetch', () => {
},
},
})
.expect({
span: container => {
const spans = container.items;
expect(spans).toHaveLength(4);
expect(spans.map(span => span.attributes[URL_FULL]?.value).sort()).toEqual([
`${SERVER_URL}/api/v0`,
`${SERVER_URL}/api/v1`,
`${SERVER_URL}/api/v2`,
`${SERVER_URL}/api/v3`,
]);

for (const span of spans) {
expect(span.attributes[SENTRY_OP]?.value).toBe(HTTP_CLIENT);
expect(span.is_segment).toBe(true);
}
},
})
.start()
.completed();
closeTestServer();
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/requests/fetch-unsampled/instrument.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracePropagationTargets: [/\/v0/, 'v1'],
Expand Down
Loading