Repository navigation
test(node): Port outgoing HTTP client spans to streaming - #25192
Merged
Merged
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 9, 2026 06:37
nicohrubec
requested review from
Lms24,
isaacs and
mydea
and removed request for
a team
October 9, 2026 06:37
Lms24
approved these changes
Oct 9, 2026
| import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner'; | ||
|
|
||
| describe('http.client span with streaming enabled', () => { | ||
| describe('http.client span without a local parent', () => { |
Member
There was a problem hiding this comment.
l: just as an addition, in this test we should assert on span.is_segment: true.
Co-Authored-By: GPT-6 <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise outgoing request hooks, header collection, query handling, and fetch errors through streamed spans. Preserve the existing basic HTTP and fetch transaction suites as static coverage, along with the request and correlation checks in the migrated cases.
Part of #24135