Repository navigation
fix(sveltekit): Stop adapter-node 6 output dir probe from deleting the build - #25193
Merged
Merged
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 06b4421. Configure here.
…e build To learn the Node adapter's output directory we call its adapt() with a stub builder. adapter-node 6 deletes its output dir with fs.rmSync before it uses the builder, so loading the Vite config (vite dev, svelte-kit sync, ...) wiped the user's build/ folder. Run adapt() from an empty temp cwd so the relative delete hits the temp dir instead. The stub builder also only had the SvelteKit 2 config shape (config.kit.paths), so adapter-node 6 threw before reporting a custom out dir and we fell back to build. Provide the SvelteKit 3 shape (config.paths) as well. Fixes #25186 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chargome
force-pushed
the
fix-sentry-js-issue-25186
branch
from
October 8, 2026 15:34
06b4421 to
4ed6ff3
Compare
chargome
marked this pull request as ready for review
October 9, 2026 09:19
chargome
requested review from
Lms24,
nicohrubec and
s1gr1d
and removed request for
a team
October 9, 2026 09:19
s1gr1d
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To find the Node adapter's output directory, we call the adapter's
adapt()with a stub builder. adapter-node 6 deletes its output folder withfs.rmSyncbefore it uses the builder, so every Vite config load (vite dev,svelte-kit sync,vite build) wiped the user'sbuild/folder. We now calladapt()from an empty temp cwd, so the delete hits the temp folder instead.This also fixes custom
outdetection with SvelteKit 3. The stub builder only had the SvelteKit 2 config shape, so adapter-node 6 threw early and we always fell back tobuild.An absolute
outpath is still deleted, since the temp cwd only protects relative paths.Fixes #25186