Skip to content

test(node): Port HTTP propagation and transport suites to streaming #25197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 2 commits into from
Oct 9, 2026
Merged

test(node): Port HTTP propagation and transport suites to streaming #25197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
677cf78
test(node): Port HTTP propagation and transport suites to streaming
nicohrubec Oct 8, 2026
3ae2e98
test(node): Restore propagation expectation comment
nicohrubec Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/ipv6/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@[2001:db8::1]/1337',
defaultIntegrations: false,
sendClientReports: false,
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/proxy/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ proxy.listen(0, () => {
const proxyPort = proxy.address().port;

Sentry.init({
traceLifecycle: 'static',
dsn: process.env.SENTRY_DSN,
transportOptions: {
proxy: `http://localhost:${proxyPort}`,
Expand Down
1 change: 0 additions & 1 deletion ...-tests/suites/tracing/tracePropagationTargets/baggage-org-id/server-no-explicit-org-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry
export type TestAPIResponse = { test_data: { host: string; 'sentry-trace': string; baggage: string } };

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@o01234987.ingest.sentry.io/1337',
release: '1.0',
environment: 'prod',
Expand Down
1 change: 0 additions & 1 deletion ...tegration-tests/suites/tracing/tracePropagationTargets/baggage-org-id/server-no-org-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry
export type TestAPIResponse = { test_data: { host: string; 'sentry-trace': string; baggage: string } };

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@public.ingest.sentry.io/1337',
release: '1.0',
environment: 'prod',
Expand Down
1 change: 0 additions & 1 deletion ...es/node-integration-tests/suites/tracing/tracePropagationTargets/baggage-org-id/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry
export type TestAPIResponse = { test_data: { host: string; 'sentry-trace': string; baggage: string } };

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@o0000987.ingest.sentry.io/1337',
release: '1.0',
environment: 'prod',
Expand Down
1 change: 0 additions & 1 deletion dev-packages/node-integration-tests/suites/tracing/tracePropagationTargets/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
traceLifecycle: 'static',
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/node-integration-tests/suites/tracing/tracePropagationTargets/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ test('HttpIntegration should instrument correct requests when tracePropagationTa
await createRunner(__dirname, 'scenario.ts')
.withEnv({ SERVER_URL })
.expect({
transaction: {
// we're not too concerned with the actual transaction here since this is tested elsewhere
span: {
// Span contents are tested elsewhere.
},
})
.start()
Expand Down
Loading