ci(e2e): Run E2E tests with pnpm 12 by s1gr1d · Pull Request #25334 · getsentry/sentry-javascript

s1gr1d · 2026-10-13T15:28:20Z

Moves the E2E tests from pnpm 9 to pnpm 12. Volta still manages node.

Every app has a pnpm-workspace.yaml. pnpm 11+ reads its settings only from this file.
- allowBuilds: pnpm 11+ fails the install on build scripts that are not listed. false is only for scripts that just print a message.
- minimumReleaseAge: 0: by default, pnpm 11+ installs only releases that are at least 24 hours old, and falls back to older versions. The apps test against the newest releases, so the E2E runner fails if an app does not set it.
Updated to @electron/rebuild ^4.2.1. Older versions depend on @electron/node-gyp from git, and pnpm 11+ blocks git dependencies of dependencies.
Ignored overrides fixed. The bundler-plugin fixtures had overrides in package.json#pnpm, and some apps used package.json#resolutions. pnpm 11+ ignores both without an error. The E2E runner now fails if an app still uses them.
Test app fixes for pnpm 12.
- The Next.js tests and build assertions read the installed version from next/package.json. pnpm add next@15 now saves ^15.x.y, and the old version checks did not work with the ^.
- The tanstackstart apps use "nitro": "^3.0.0", because pnpm 12 resolved latest || * to the placeholder nitro@0.0.0. This installs the same nitro@3.0.0 as pnpm 9. A follow-up moves them to the nitro beta, which needs Vite 8.
- 7 apps no longer run npx playwright install in test:build. CI already installs the app's Playwright version, and the second install ran at the same time and failed.

Why pnpm is a root dev dependency

pnpm switches to the version in a packageManager field, but a pnpm must already be installed to do that. Yarn installs that first pnpm as a dev dependency, because Volta can't run pnpm 12 and is unmaintained. The pnpm package is a native binary, so it does not depend on the node version that an app pins. yarn.lock pins the version, so local runs and CI use the same pnpm. Contributors need no extra setup, and CI caches pnpm with node_modules.

Rejected alternatives:

pnpm/action-setup alone: it only installs pnpm in CI. Contributors would have to install pnpm themselves, and their version could differ from CI.
Corepack: it is deprecated, and Node 25 no longer includes it.
mise: no getsentry JS repo uses it, and contributors would need one more tool (alongside Volta).

⚠️ @JPeer264 When the repo moves from Yarn to pnpm, remove the dev dependency and set packageManager in the root package.json. A test app can still pin another pnpm version (10.30 or newer, which reads allowBuilds) with its own packageManager field.

chore: Move the monorepo from Yarn 1 to pnpm 12 #25354

Volta cannot run pnpm 12, so pnpm is now a root devDependency. Volta only pins node per app. pnpm 11+ reads settings only from pnpm-workspace.yaml and blocks unlisted build scripts, so each app now has a pnpm-workspace.yaml with allowBuilds and minimumReleaseAge: 0.

mydea · 2026-10-14T14:11:15Z

    "typescript": "~5.8.3",
    "vite": "^7.3.2"
  },
  "volta": {


not directly related to this test, but we should actually replace these with a reference to the workspace volta config.

(I may open a PR to update this everywhere)

mydea · 2026-10-14T14:20:44Z

Semi related, opened #25369 to actually update volta config in e2e test apps to better align with the fact we are using node 24 anyhow now by default!

# Conflicts: # dev-packages/e2e-tests/test-applications/browser-bfcache/package.json # dev-packages/e2e-tests/test-applications/browser-mfe-vite/package.json # dev-packages/e2e-tests/test-applications/browser-webworker-vite/package.json # dev-packages/e2e-tests/test-applications/remix-v3/package.json

# Conflicts: # dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/rolldown/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/rollup3/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/rollup4/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/vite4/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/vite6/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/vite7/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/vite8/package.json # dev-packages/bundler-plugin-integration-tests/fixtures/webpack5/package.json

JPeer264

LGTM. Just added nits mostly

JPeer264 · 2026-10-15T11:03:36Z

 - **Packed tarballs missing**: Run `yarn build:tarball` at the repo root, then `yarn test:prepare` in `dev-packages/e2e-tests`
 - **Build failures**: Fix build errors before running tests
- **pnpm errors such as `packages field missing or empty`**: The app needs the pnpm version in its `volta.pnpm`. Run with Volta, which installs that version
+- **`ERR_PNPM_IGNORED_BUILDS`**: A dependency has a build script that the app's `allowBuilds` does not list. Add it to the app's `pnpm-workspace.yaml`: `true` if the app needs the script, `false` if the script only prints a message


l: Theoretically pnpm approve-builds is adding it - maybe worth to add this here

JPeer264 · 2026-10-15T11:05:28Z

  steps:
-    - name: Resolve pnpm version
-      id: pnpm-version
+    # The devDependency is the one pnpm version for CI and local runs. An app that needs another version sets


super-l: It is weird that it is written devDependency and not "dev dependency" - maybe we can rename it to the latter. First I read it any thought that something is off 😅

Suggested change

# The devDependency is the one pnpm version for CI and local runs. An app that needs another version sets

# The dev dependency is the one pnpm version for CI and local runs. An app that needs another version sets

JPeer264 · 2026-10-15T11:12:16Z

@@ -0,0 +1 @@
+minimumReleaseAge: 0


q/l: Couldn't we make one more global pnpm-workspace.yaml in the e2e test root and copy it over into each directory? Theoretically we don't treat each folder as own workspace, but we potentially forget to set minimumRelaseAge: 0 on new tests.

If we keep it though, we should add a bugbot rule that this is set as a minimum on new e2e tests or make sure in our runners that this is set. wdyt?

I'll add a rule for that 👍

JPeer264 · 2026-10-15T11:16:25Z

    "react": "^19.2.0",
    "react-dom": "^19.2.0",
-    "nitro": "latest || *",
+    "nitro": "^3.0.0",


q: Is that change necessary in this PR? Or was it required to be changed

yes, listed in the PR description:

The tanstackstart apps use "nitro": "^3.0.0", because pnpm 12 resolved latest || * to the placeholder nitro@0.0.0. This installs the same nitro@3.0.0 as pnpm 9. A follow-up moves them to the nitro beta, which needs Vite 8.

Thanks for confirming. Sorry I forgot the PR description after scrolling through all the changes 😅

JPeer264 · 2026-10-15T11:16:36Z

    "react": "^19.2.0",
    "react-dom": "^19.2.0",
-    "nitro": "latest || *",
+    "nitro": "^3.0.0",


same as https://github.com/getsentry/sentry-javascript/pull/25334/changes#r4282274277

s1gr1d added 5 commits October 13, 2026 17:28

Merge branch 'develop' into sig/e2e-pnpm-12

2da7679

fix CI failures

b4f49bd

Merge branch 'develop' into sig/e2e-pnpm-12

dad0c87

fix CI failures

8d75018

s1gr1d marked this pull request as ready for review October 14, 2026 10:26

JPeer264 mentioned this pull request Oct 14, 2026

chore: Move the monorepo from Yarn 1 to pnpm 12 #25354

Open

s1gr1d requested review from JPeer264 and mydea October 14, 2026 11:17

fix other next.js tests

29ae346

mydea reviewed Oct 14, 2026

View reviewed changes

Comment thread dev-packages/bundler-plugin-integration-tests/fixtures/esbuild/package.json Outdated

mydea reviewed Oct 14, 2026

View reviewed changes

Comment thread dev-packages/e2e-tests/test-applications/aws-serverless-layer/package.json Outdated

s1gr1d mentioned this pull request Oct 14, 2026

test(e2e): Inherit root Volta config in all e2e test apps #25369

Merged

JPeer264 added this pull request to stack #25387 October 15, 2026 08:47

s1gr1d added 2 commits October 15, 2026 12:53

fix comment

2c7f5cd

JPeer264 approved these changes Oct 15, 2026

View reviewed changes

review suggestions

abc991b

s1gr1d merged commit 1c5303c into develop Oct 15, 2026
1096 of 1103 checks passed

s1gr1d deleted the sig/e2e-pnpm-12 branch October 15, 2026 14:24

mydea mentioned this pull request Oct 15, 2026

ci(e2e): Run E2E tests without restoring the monorepo's node_modules #25403

Draft

	# The devDependency is the one pnpm version for CI and local runs. An app that needs another version sets
	# The dev dependency is the one pnpm version for CI and local runs. An app that needs another version sets

Conversation

s1gr1d commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mydea commented Oct 14, 2026

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

s1gr1d commented Oct 13, 2026 •

edited

Loading