Repository navigation
ci: Keep Namespace cache volumes complete and cache the pnpm binary - #25569
Merged
Merged
Conversation
JPeer264
enabled auto-merge (squash)
October 20, 2026 16:39
JPeer264
disabled auto-merge
October 20, 2026 17:23
Namespace keeps the cache volume of every job that exits cleanly, and the last write wins. E2E jobs and jobs without cache use had the same tag as the dependency volume, so they often committed an empty or E2E-only volume, and the next Build installed all dependencies again. E2E jobs now use their own tag, and jobs without cache use have no tag. `pnpm/action-setup` downloads pnpm with `pnpm self-update` in every job. The new `mount-pnpm-store` action mounts the pnpm store and the npm cache before `install-pnpm`, so both downloads come from the cache volume. The `pnpm` mode of nscloud-cache-action runs pnpm, so the action sets `PNPM_CONFIG_STORE_DIR` itself until the mode works without pnpm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/namespace-cache-tags
branch
from
October 21, 2026 06:48
12b109e to
b18c6c1
Compare
Contributor
size-limit report 📦Compared: d992a4d (PR test merge using develop at 3f00b10) Against: 3f00b10 (develop) · base run #62855 ✅ Baseline matches: this diff contains only this PR's changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the E2E jobs their own Namespace cache tag and removes the tag from jobs that do not use a cache. A new
mount-pnpm-storeaction mounts the pnpm store and the npm cache beforeinstall-pnpm, so pnpm itself also comes from the cache volume.Why
Namespace keeps the volume of the last job that exits cleanly. E2E jobs and jobs without cache use often finished last, so Build got no
node_modulesin about 8 of 10 runs.pnpm self-updatealso downloaded pnpm in every job, which took up to 130s.Cache decisions
cache: pnpmruns pnpm, so it cannot come beforeinstall-pnpm. Until Namespace changes this,mount-pnpm-storesetsPNPM_CONFIG_STORE_DIRitself.