Skip to content

test(node): Retry stalled npm installs in integration test setup #25685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mydea wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

test(node): Retry stalled npm installs in integration test setup #25685

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
937d227
test(node): Retry stalled npm installs in integration test setup
mydea Oct 23, 2026
777a965
test(node): Lower integration test setup hook timeout to 200s
mydea Oct 23, 2026
9d8e8b6
test(node): Clean up partial npm installs before retrying
mydea Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions dev-packages/node-integration-tests/utils/runner/createEsmAndCjsTests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { exec } from 'child_process';
import { exec, execFile } from 'child_process';
import { existsSync } from 'fs';
import { cp, mkdir, readFile, rm, writeFile } from 'fs/promises';
import { basename, delimiter, join } from 'path';
Expand All @@ -7,6 +7,7 @@ import { afterAll, beforeAll, test, type TestAPI } from 'vitest';
import { CLEANUP_STEPS, createRunner, PACKAGE_ROOT } from './createRunner';

const execPromise = promisify(exec);
const execFilePromise = promisify(execFile);

interface ScenarioPaths {
cjs: {
Expand Down Expand Up @@ -161,10 +162,11 @@ function setupAndCleanup(
createdRunners: Set<ReturnType<typeof createRunner>>,
tmpDirPath: string,
) {
// Create tmp directory and install additionalDependencies (with retries)
// Create tmp directory and install additionalDependencies (with retries).
// Must cover all npm install attempts (see `NPM_INSTALL_TIMEOUT_MS`) plus `afterSetupCommand`.
beforeAll(async () => {
await createTmpDir();
}, 120_000);
}, 200_000);

// Clean up the tmp directory after both esm and cjs suites have run
afterAll(async () => {
Expand Down Expand Up @@ -332,17 +334,23 @@ function convertEsmToCjs(content: string): string {

const NPM_INSTALL_MAX_RETRIES = 3;
const NPM_INSTALL_RETRY_DELAY_MS = 2_000;
// npm install can stall on CI without ever failing, which would otherwise use up the whole setup hook timeout
// before a retry gets a chance to run.
const NPM_INSTALL_TIMEOUT_MS = 60_000;

async function npmInstallWithRetry(cwd: string, deps: string[]): Promise<void> {
for (let attempt = 1; attempt <= NPM_INSTALL_MAX_RETRIES; attempt++) {
try {
const { stdout, stderr } = await execPromise(
// Run npm without a shell, so the timeout kills npm itself rather than leaving it running next to the retry
const { stdout, stderr } = await execFilePromise(
'npm',
// We only use --prefer-offline on the first attempt to try to read from cache
// in follow ups we just try to install in any way
`npm install ${attempt === 1 ? '--prefer-offline' : ''} --no-audit --no-fund`,
['install', ...(attempt === 1 ? ['--prefer-offline'] : []), '--no-audit', '--no-fund'],
{
cwd,
encoding: 'utf8',
timeout: NPM_INSTALL_TIMEOUT_MS,
},
);

Expand All @@ -362,6 +370,9 @@ async function npmInstallWithRetry(cwd: string, deps: string[]): Promise<void> {
`npm install attempt ${attempt}/${NPM_INSTALL_MAX_RETRIES} failed, retrying in ${NPM_INSTALL_RETRY_DELAY_MS}ms...`,
);
await new Promise(resolve => setTimeout(resolve, NPM_INSTALL_RETRY_DELAY_MS));
// A killed attempt leaves a partial install behind, which the next attempt would treat as complete
await rm(join(cwd, 'node_modules'), { recursive: true, force: true });
await rm(join(cwd, 'package-lock.json'), { force: true });
} else {
// oxlint-disable-next-line no-console
console.error(error);
Expand Down
Loading