Repository navigation
Conversation
… workers don't crash on import Webpack-built OpenNext workers have an empty `__filename`, so the module-scope `createRequire` in `config/util` threw as soon as the server entry was imported, failing the instrumentation hook on every request.
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webpack-built OpenNext workers have an empty
__filename, so the module-scopecreateRequireinconfig/utilthrew on import and failed the instrumentation hook, fixed by creating that require insideresolveNextjsPackageJson.To test this properly we would need to add an app specifically to test this, which doesn't seem worth it for v10. This issue doesn't occur in v11 because the server entry no longer exports config paths, so the
createRequirecall is never evaluated.closes #25683