Repository navigation
feat(boto3): Add Lambda extension - #8117
Open
pabloDeputter wants to merge 5 commits into
Open
pabloDeputter wants to merge 5 commits into
pabloDeputter wants to merge 5 commits into
Conversation
pabloDeputter
changed the title
pabloDeputter
marked this pull request as ready for review
October 23, 2026 14:45
Contributor
Coverage Results 📊✅ 57643 passed | ⏭️ 2979 skipped | Total: 60622 | Pass Rate: 95.09% | Execution Time: 158m 30s All tests are passing successfully. ✅ Patch coverage is 98.80% (82 of 83 changed executable lines covered; target 80%). Changed files with executable lines (7)
Coverage diff@@ Coverage Diff @@
## master #8117 +/-##
==========================================
- Coverage 90.29% 90.20% -0.09%
==========================================
Files 203 198 -5
Tracked lines 26883 21389 -5494
Branches 10046 7402 -2644
==========================================
- Hits 24272 19292 -4980
+ Misses 2611 2097 -514
+ Partials 1518 1240 -278Generated by Coverage Action |
sentrivana
added a commit
that referenced
this pull request
Oct 29, 2026
### Description Removes `AwsCallContext.service_id_hyphenized` from `sentry_sdk/integrations/boto3/_context.py`. It's still computed on every call (`service_id.hyphenize()`), but on `major/3.0` nothing reads it. It had two readers. One was the `aws.service_id` span tag, which #7261 ("Drop tags auto-set by the SDK") removed. The other was the span name: #7800 ("align span names with OTel conventions") switched that to `ctx.service_id`, so the hyphenized value lost its last reader. This removes the slot, the attribute and the `hyphenize()` call. **Evidence** - On `major/3.0`, `git grep -w service_id_hyphenized` matches only the three lines in `_context.py` that set it up. - The open boto3 extension PRs against `major/3.0` (#8117 SQS, #8137 Lambda) don't reference it. On `master`, `service_id_hyphenized` is still used for the span name and the tag, so this only applies to `major/3.0`. #### Issues n/a <!-- junior-request-attribution:start --> via **Ivana Kellyer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0BTREZTS2Z%3A1793270559.842119 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following attributes:
faas.invoked_name(function name),faas.invoked_provider(aws),faas.invoked_region(region extracted from ARN, else the client's) (all from OTel) onInvoke,InvokeWithResponseStreamandInvokeAsyncaws.lambda.target_function.nameon every other API withFunctionName(feat(attributes): Add AWS Lambda, Step Functions and Secrets Manager name attributes sentry-conventions#716)aws.lambda.resource_mapping.idon the event source mapping APIs, from the request or responseUUIDOther changes:
FunctionErrorsetserror.type=lambda_function_errorClientContext.customis available, we add trace propagation headers; trace continuing in aws-lambda integration is not done yetIssues
Resolves #8069
Part of #8071