fix(analytics): Attribute setup docs by project creation variant#120143
Open
jaydgoss wants to merge 1 commit into
Open
fix(analytics): Attribute setup docs by project creation variant#120143jaydgoss wants to merge 1 commit into
jaydgoss wants to merge 1 commit into
Conversation
Move project-creation setup-docs events out of onboarding counters and carry SCM versus legacy in variant. Forward an explicit creation marker to the shared page so experiment enrollment cannot misattribute unrelated projects; unmarked surfaces keep the canonical event without a guessed variant. Refs VDY-133
github-actions
Bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
No base snapshots found to compare against. Make sure snapshots are uploaded from your main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Moves project-creation setup-docs activity out of
onboarding.*counters and onto sharedproject_creation.*events, segmented byvariant: 'scm' | 'legacy'from an explicit creation-flow marker.Details
This PR is stacked on the behavior-preserving
docsFlowrefactor (#119937). It contains the analytics contract change separately so reviewers can evaluate event names, dimensions, and BI discontinuities without also reviewing the boolean-to-enum plumbing.Legacy
CreateProjectandScmCreateProjectnow forwardprojectCreationVariant=legacy|scmwhen navigating to the shared getting-started page.ProjectInstallPlatformderivesdocsFlowfrom that marker rather than from experiment enrollment: enrolled users can visit older or unrelated projects, so the experiment alone is not evidence that the current page came from SCM creation. Unmarked peripheral surfaces use the canonical project-creation event names without a guessed variant.The two marked project-creation arms resolve to the same
project_creation.*names for DSN copy, next step, JS-loader, setup-loader, source-map, and framework interactions.docsFlowVariantParamssupplies the SCM/legacy split at each fire site; onboarding and SCM onboarding keep their existing distinct names and never receive the project-creation variant. The project-creation registry gains the missing base setup-docs events.setup_guide.copy_as_markdownfollows the shared-param model:sourcecontains only the flow (first_time_setuporproject_getting_started) andvariantcontains SCM-ness. This intentionally removes the_scmsource values, including SCM onboarding; unmarked surfaces retain the project source without a variant. Gaming origin remains on its existing two-value taxonomy.Coverage verifies the collapsed event maps, all four marked flow variants, unmarked behavior, and both create paths forwarding the correct marker while preserving SCM product-selection query parameters.
BI note: project-creation DSN/next-step/loader traffic leaves the polluted onboarding counters; copy-as-markdown
_scmsource values move to base source +variant.Refs VDY-133