feat(analytics): Attribute getting-started header actions by variant#120147
Open
jaydgoss wants to merge 1 commit into
Open
Conversation
Stamp projectCreationVariant onto the existing project_creation header events (back_button_clicked, data_removal_modal_confirm_button_clicked, data_removed) so abandonment on the shared getting-started page is segmentable by SCM vs legacy. Unmarked peripheral entry keeps the same names without a guessed variant. Dead modal rendered/dismissed keys stay unwired. Refs VDY-133
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
marked this pull request as ready for review
July 20, 2026 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The shared getting-started header’s back / silent-delete analytics now carry
variant: 'scm' | 'legacy'when the page was reached from project creation, so abandonment can be segmented without new event names.Details
Stacked on the getting-started funnel PR (#120131), which already consumes the
?projectCreationVariant=forward-nav marker on this page for the view event and “Take me to Issues”. This PR extends that marker intoPlatformDocHeader, the abandonment surface on the same page.ProjectInstallPlatformpasses the validated marker intoPlatformDocHeader. On back click the header still fires the three existing live counters —project_creation.back_button_clicked,project_creation.data_removal_modal_confirm_button_clicked(name is historical; there is no modal — back-nav deletes an inactive project directly), andproject_creation.data_removedafter a successful delete. When the marker is present each payload gainsvariant; when it is missing the same names fire without a variant, so peripheral entry points (older projects, non-creation links) are not guessed into SCM or legacy. The typed params gain optionalvariantto match. The two dead registry keys (data_removal_modal_rendered/_dismissed) stay unwired — flagged in a one-line comment only.Coverage extends the existing getting-started analytics helper: both marked variants assert all three events carry the right
variantthrough the inactive-project delete path, and the unmarked path asserts the same events fire without avariantfield.Refs VDY-133