feat(np): Adds renderer for MSTeams issue alerts - #124860
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
3 times, most recently
from
September 18, 2026 22:26
7572f39 to
9333505
Compare
hobzcalvin
added this pull request to stack #124985
September 18, 2026 22:41
hobzcalvin
marked this pull request as ready for review
September 18, 2026 22:43
hobzcalvin
requested review from
GabeVillalobos,
leeandher,
saponifi3d and
shayna-ch
September 18, 2026 22:44
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 21, 2026 16:34
9333505 to
d975181
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 21, 2026 23:11
d975181 to
acda67c
Compare
Contributor
Sentry Snapshot Testing
|
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
2 times, most recently
from
September 21, 2026 23:44
f62fa24 to
ee745d1
Compare
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 22, 2026 00:04
ee745d1 to
742a552
Compare
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 22, 2026 17:48
742a552 to
34cbd30
Compare
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 22, 2026 17:58
34cbd30 to
477eb0e
Compare
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 22, 2026 20:05
477eb0e to
5c46be1
Compare
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
2 times, most recently
from
September 22, 2026 21:02
ad19702 to
d198ff5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d198ff5. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
shayna-ch
reviewed
Sep 22, 2026
| if not isinstance(data, IssueNotificationData): | ||
| raise ValueError(f"IssueMSTeamsRenderer does not support {data.__class__.__name__}") | ||
|
|
||
| from sentry.integrations.msteams.card_builder.base import MSTeamsMessageBuilder |
Member
There was a problem hiding this comment.
think this would be better at the top unless its causing an import error
Contributor
Author
There was a problem hiding this comment.
Yeah, I never want inline imports, but there's a big complex set of reasons why it works out this way, involving other renderers, the jira-app-id that comes from sentry options...at least this is building on precedent from other renderers.
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 22, 2026 23:00
d198ff5 to
91bce24
Compare
Annotates _build_expected_card as returning an AdaptiveCard and types its actions list, resolving mypy errors in the MSTeams issue renderer tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
`sentry.notifications.apps.Config.ready` imports this renderer, and importing any `sentry.integrations.msteams` submodule executes that package's `__init__`, which reaches `sentry.notifications.notification_action` and from there the Jira action validator. That module reads `system.url-prefix` at import time, which asserts because `ready()` runs during `django.setup()`, before `bind_cache_to_option_store()`. Matches the Discord and Slack renderers. Co-authored-by: Cursor <cursoragent@cursor.com>
hobzcalvin
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
September 23, 2026 18:01
91bce24 to
c51c820
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #124857 (
gp/add_renderer_registry). Supersedes #112890, which could not be reopened after the branch was rebased.Summary
Adds
IssueMSTeamsRenderer, so issue alerts sent through the notification platform produce the same Adaptive Card the legacyMSTeamsIssueMessageBuilderpath produces today. The renderer registers itself for(MSTEAMS, ISSUE)with the registry from the parent PR rather than adding aget_rendereroverride to the provider.Original work by @GabeVillalobos; rebased onto current master and adapted to the registry.
Actions are limited to a single "View Issue" link. The legacy card also offers resolve/archive/assign, which need the
RpcIntegrationfor action webhook routing; that is coming in #125160