perf(derived data): Bound heal range selection with density sampling - #125093
Merged
Merged
Conversation
kcons
marked this pull request as draft
September 21, 2026 19:00
github-actions
Bot
added
the
Scope: Backend
kcons
force-pushed
the
kcons/otherway
branch
from
September 22, 2026 20:26
efb97df to
eabaa72
Compare
kcons
changed the title
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 71cbd6e. Configure here.
kcons
marked this pull request as ready for review
September 22, 2026 22:20
kcons
commented
Sep 22, 2026
| with metrics.timer("issues.derived.group_id_range_query"): | ||
|
|
||
| def fetch_group_ids(start: int, limit: int) -> list[int]: | ||
| remaining_seconds = query_deadline - time.monotonic() |
Member
Author
There was a problem hiding this comment.
nb: I have a helper for this sitting around, but didn't want to make it part of this pr. See #125142
shashjar
approved these changes
Sep 22, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
group_id_ranges_for_hash read one row for every matching group ID in the requested window, so
query cost grew linearly with the scheduling budget and large runs hit occasional timeouts. This
moves to a tunable range estimation via density sampling approach, requiring dramatically
less work for the db.
This makes ranges more approximate than they were before, so regenerate_stale_derived_data_batch caps each batch at issues.derived.heal-batch-size and reschedules the remainder when a range turns out denser than estimated.