Conversation
…ent text `Text`, `Heading`, `Link` and `InlineCode` all set `text-box-trim: trim-both`, so their boxes hug the glyphs. `Tag` did not: its label kept the font's half-leading, and `TagPill` centers that taller box. Centering a line box rather than the glyphs left the label sitting ~1.4px above the baseline of any text next to it. Most visible in the Seer markdown block embeds, whose header band centers a tag against the "View <resource>" link. The embeds that pass a `<Text>` as the badge (dashboard, log) already lined up; the six that pass a `<Tag>` (monitor, saved query, metrics, errors, spans, logs) did not. Measured in Chromium at 14px/Rubik, header band 36px, pill 20px: before tag -> link baseline: 1.41px title -> link baseline: 0.50px after tag -> link baseline: 0.50px title -> link baseline: 0.50px The tag now sits exactly where the header's own title does; the remaining 0.5px is the inherent offset between co-centered 12px and 14px text, and both land on the same device pixel. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-34dguioj5.sentry.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seer markdown block embeds show a tag in the header band, to the left of the
"View " link. The tag's label sat ~1.4px above the link's baseline.
Cause
Text,Heading,LinkandInlineCodeall settext-box-trim: trim-both,so their boxes hug the glyphs.
Tagdid not — its label kept the font'shalf-leading, and
TagPillcenters that taller box. Centering a line boxrather than the glyphs is what pushed the label up.
That also explains which embeds looked wrong: the ones passing a
<Text>asthe badge (
dashboardBlock,logBlock) already lined up; the six passing a<Tag>(monitor, saved query, metrics, errors, spans, logs) did not.Fix
Give
TagTextthe same trim the rest of the text system uses.Evidence
Measured in Chromium at 14px/Rubik, header band 36px, pill 20px — baseline
deltas relative to the link:
The tag now sits exactly where the header's own title does. The remaining
0.5px is the inherent offset between co-centered 12px and 14px text; both
land on the same device pixel.
Scope
Tagis a core component, so this nudges the label ~1px down inside everypill in the product — toward consistency with every other text primitive.
Worth a look from design if that's broader than wanted; the alternative is
scoping the same trim to the Seer embed header.
Tests
static/app/components/core/badge(4 suites) and the Seer embed suites(
seerEmbedBlock,monitor) pass;stylelintandoxfmtclean.🤖 Generated with Claude Code