Skip to content

ref(spike-protection): Convert SpikeProtectionHistoryTable to functional component #125148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan953 merged 3 commits into from
Sep 24, 2026
Merged

ref(spike-protection): Convert SpikeProtectionHistoryTable to functional component #125148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a4f0c3
ref(spike-protection): Convert SpikeProtectionHistoryTable to functio…
ryan953 Sep 21, 2026
6e7e9e9
ref(spike-protection): Split history table helpers into components
ryan953 Sep 23, 2026
d84b2c3
ref(spike-protection): Replace HoCs with hooks in history table
ryan953 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/gsApp/overrides/spendVisibility/enhancedUsageStatsOrganization.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {withSubscription} from 'getsentry/components/withSubscription';
import {type Subscription} from 'getsentry/types';
import {SPIKE_PROTECTION_OPTION_DISABLED} from 'getsentry/views/spikeProtection/constants';
import {SpikeProtectionRangeLimitation} from 'getsentry/views/spikeProtection/spikeProtectionCallouts';
import SpikeProtectionHistoryTable from 'getsentry/views/spikeProtection/spikeProtectionHistoryTable';
import {SpikeProtectionHistoryTable} from 'getsentry/views/spikeProtection/spikeProtectionHistoryTable';
import SpikeProtectionUsageChart from 'getsentry/views/spikeProtection/spikeProtectionUsageChart';
import type {
Spike,
Expand Down
12 changes: 6 additions & 6 deletions static/gsApp/views/spikeProtection/spikeProtectionHistoryTable.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {DATA_CATEGORY_INFO} from 'sentry/constants';
import {DataCategoryExact} from 'sentry/types/core';

import {SubscriptionStore} from 'getsentry/stores/subscriptionStore';
import SpikeProtectionHistoryTable from 'getsentry/views/spikeProtection/spikeProtectionHistoryTable';
import {SpikeProtectionHistoryTable} from 'getsentry/views/spikeProtection/spikeProtectionHistoryTable';
import type {SpikeDetails} from 'getsentry/views/spikeProtection/types';

import {SPIKE_PROTECTION_OPTION_DISABLED} from './constants';
Expand Down Expand Up @@ -36,7 +36,7 @@ describe('SpikeProtectionHistoryTable', () => {
});
});

it('renders an empty state when no spikes are provided', async () => {
it('renders an empty state when no spikes are provided', () => {
render(
<SpikeProtectionHistoryTable
spikes={[]}
Expand All @@ -47,7 +47,7 @@ describe('SpikeProtectionHistoryTable', () => {
{organization}
);

const emptyState = await screen.findByTestId('spike-history-empty');
const emptyState = screen.getByTestId('spike-history-empty');
expect(emptyState).toBeInTheDocument();
const emptyMessage = screen.getByText(/No Significant Spikes/);
expect(emptyMessage).toBeInTheDocument();
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('SpikeProtectionHistoryTable', () => {
/>,
{organization}
);
await screen.findByTestId('spike-protection-history-table');
screen.getByTestId('spike-protection-history-table');
screen.getByText('2wk');
screen.getByText('1.3M');
screen.getByText('500K');
Expand All @@ -125,7 +125,7 @@ describe('SpikeProtectionHistoryTable', () => {
);
});

it('renders ongoing stored spike', async () => {
it('renders ongoing stored spike', () => {
const storedSpikes: SpikeDetails[] = [
{
start: new Date(2022, 0, 2, 6, 0, 0, 0).toISOString(),
Expand All @@ -145,7 +145,7 @@ describe('SpikeProtectionHistoryTable', () => {
{organization}
);

await screen.findByTestId('spike-protection-history-table');
screen.getByTestId('spike-protection-history-table');
screen.getByText('Ongoing');
screen.getByText('200K');
screen.getByText('Jan 2, 2022 - present');
Expand Down
Loading
Loading