ref(discover): Convert ResultsChart components to functional - #125150
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts two React class components,
ResultsChartandResultsChartContainer, located instatic/app/views/discover/results/resultsChart.tsx, into functional components using React hooks.Specifically, for
ResultsChartContainer:yAxisOptionsstate andUNSAFE_componentWillReceivePropslifecycle method have been replaced with auseMemohook to deriveyAxisOptionsfromeventView.shouldComponentUpdatemethod has been replaced by wrapping the functional component inReact.memowith a custom comparison function.CustomMeasurementsContext.Consumerrender prop has been updated to use theuseContexthook.withApiHigher-Order Component has been removed, and theapiclient is now obtained using theuseApihook directly within the component.For
ResultsChart:shouldComponentUpdatemethod has been replaced by wrapping the functional component inReact.memowith a custom comparison function.These changes align the components with the project's
no-class-componentscoding convention, improving maintainability and leveraging modern React practices.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-4R7
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run