Skip to content

fix(seer): Stop drawing an empty reasoning box while Seer works #125151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan953 merged 1 commit into from
Sep 22, 2026
Merged

fix(seer): Stop drawing an empty reasoning box while Seer works #125151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion static/app/views/seerExplorer/components/chat/responseGroup.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {OrganizationFixture} from 'sentry-fixture/organization';

import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary';
import {render, screen, userEvent, within} from 'sentry-test/reactTestingLibrary';

import type {Block} from 'sentry/views/seerExplorer/types';

Expand Down Expand Up @@ -318,6 +318,9 @@ describe('ResponseGroup', () => {
);

expect(queryReasoningBox(container)).toBeInTheDocument();
// Title only. The panel is the bordered card, so opening it around nothing draws an
// empty box under "Thinking..." for as long as the agent takes to report anything.
expect(within(reasoningBox(container)).queryByRole('group')).not.toBeInTheDocument();
});

it('gates thinking prose on the showThinking toggle but keeps tool calls', async () => {
Expand Down
5 changes: 4 additions & 1 deletion static/app/views/seerExplorer/components/chat/responseGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,10 @@ export function ResponseGroup({
startTime={startTime}
endTime={endTime}
>
{active || hasTrace
{/* `hasTrace`, not `active`: an active response with nothing to show yet still
maps to a non-empty array of blocks that each render nothing, and an array is
truthy, so ThinkingBlock would open its bordered panel around no content. */}
{hasTrace
? group.map((block, i) => {
const isAnswer = block === answer;
// A block's own tool calls render after its thinking, so they count as
Expand Down
Loading