fix(coding-conventions): Migrate ReleaseSeries class component to hook - #125156
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Contributor
📊 Type Coverage Diff
🔍 4 new type safety issues introduced
This is informational only and does not block the PR. |
sentry
Bot
force-pushed
the
seer/ref-release-series-hook
branch
from
September 21, 2026 23:16
ea5f26e to
032554c
Compare
sentry
Bot
force-pushed
the
seer/ref-release-series-hook
branch
from
September 21, 2026 23:22
5c8a46d to
fef8e0c
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0a2ae4b. Configure here.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR addresses the
no-class-componentslinting rule violation instatic/app/components/charts/releaseSeries.tsx.The
ReleaseSeriescomponent was a deprecated React class component, marked with@deprecated use useReleaseBubbles instead. To comply with coding conventions and improve maintainability, its logic has been refactored into a newuseReleaseSeriesReact hook.Changes Made:
static/app/components/charts/releaseSeries.tsx:ReleaseSeriesclass component has been removed.useReleaseSerieshook.ReleaseSeriescomponent is now a thin functional component that uses theuseReleaseSerieshook and maintains its render-prop API for backward compatibility.withApi,withOrganization, andwithThemeHOCs have been replaced with their respective hooks (useApi,useOrganization,useTheme).emphasizeReleases = []default in the hook's signature, which caused an infinite render loop due to creating a new array reference on every render, has been removed. A stableemphasizeReleasesKey(serialized string) is now used as a dependency for the relevantuseEffect.useEffectresponsible for data fetching previously used reference equality forstart,end,projects, andenvironments. This led to unnecessary refetches and error toasts when these props (e.g., Date objects, arrays) were recreated with the same values by callers. This has been fixed by introducing stable serialized keys (startKey,endKey,projectsKey,environmentsKey) for these dependencies, ensuring value-based comparison.static/app/views/insights/common/components/chart.tsx:useReleaseSerieshook instead of the<ReleaseSeries>render-prop component.static/app/views/projectDetail/charts/projectBaseSessionsChart.tsx:useReleaseSerieshook instead of the<ReleaseSeries>render-prop component.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes CODING-CONVENTIONS-56H
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run