Skip to content

chore(derived data): Default issues.action_log.use_db_sequence_for_outbox_identifier to False #125157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcons merged 2 commits into from
Sep 22, 2026
Merged

chore(derived data): Default issues.action_log.use_db_sequence_for_outbox_identifier to False #125157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ced924b
chore(derived data): Default issues.action_log.use_db_sequence_for_ou…
kcons Sep 21, 2026
781b02a
update tests
kcons Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/options/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,7 @@
register(
"issues.action_log.use_db_sequence_for_outbox_identifier",
type=Bool,
default=True,
default=False,
Comment thread
cursor[bot] marked this conversation as resolved.
flags=FLAG_MODIFIABLE_BOOL | FLAG_AUTOMATOR_MODIFIABLE,
)
register(
Expand Down
8 changes: 5 additions & 3 deletions tests/sentry/issues/test_action_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,9 +600,10 @@ def test_uses_dedicated_outbox(self, mock_timer: MagicMock) -> None:
)

@patch("sentry.issues.action_log.publish.secrets.randbelow", return_value=12344)
def test_outbox_identifier_can_use_secure_random_value(self, mock_randbelow: MagicMock) -> None:
def test_outbox_identifier_uses_secure_random_value_by_default(
self, mock_randbelow: MagicMock
) -> None:
with (
self.options({"issues.action_log.use_db_sequence_for_outbox_identifier": False}),
self.feature("projects:issue-action-log-write-to-db"),
outbox_context(flush=False),
):
Expand All @@ -621,10 +622,11 @@ def test_outbox_identifier_can_use_secure_random_value(self, mock_randbelow: Mag
"sentry.issues.models.groupactionlogoutbox.GroupActionLogOutbox.next_object_identifier",
return_value=67890,
)
def test_outbox_identifier_uses_db_sequence_by_default(
def test_outbox_identifier_can_use_db_sequence(
self, mock_next_object_identifier: MagicMock
) -> None:
with (
self.options({"issues.action_log.use_db_sequence_for_outbox_identifier": True}),
self.feature("projects:issue-action-log-write-to-db"),
outbox_context(flush=False),
):
Expand Down
Loading