ref(np): Resolve MSTeams integrations from one lookup list - #125159
Merged
Merged
Conversation
hobzcalvin
added this pull request to stack #124985
September 21, 2026 23:30
github-actions
Bot
added
the
Scope: Backend
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 21, 2026 23:44
ebbaed4 to
58dee1a
Compare
Contributor
Sentry Snapshot Testing
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 22, 2026 00:04
58dee1a to
9c9c3aa
Compare
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
2 times, most recently
from
September 22, 2026 17:58
d41a19a to
b543940
Compare
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 22, 2026 20:05
b543940 to
d92b853
Compare
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 22, 2026 20:10
d92b853 to
d153254
Compare
hobzcalvin
marked this pull request as ready for review
September 22, 2026 20:53
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 22, 2026 21:02
d153254 to
83e24bf
Compare
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
2 times, most recently
from
September 23, 2026 18:01
4e13145 to
61c84bd
Compare
The request parser walked a card action id, then a team id, then a tenant id to find the integration, while the card action webhook handler only looked at the card action id and can_infer_integration only looked at the first two. Cards built by the notification platform cannot embed an integration id, since the renderer has no access to the target it is being sent to, so every caller needs the full chain. Express the chain once as an ordered list of integration_service filters and derive all three callers from it, so a request identified only by its tenant -- an action submitted from a personal chat -- resolves and is dispatched to a cell rather than falling through to the control silo. Co-authored-by: Cursor <cursoragent@cursor.com>
A tenant id identifies a personal install, whose events are served from the control silo, so it cannot stand in as a cell routing key. Co-authored-by: Cursor <cursoragent@cursor.com>
hobzcalvin
force-pushed
the
gp/msteams_integration_lookups
branch
from
September 23, 2026 18:34
61c84bd to
68dacd0
Compare
leeandher
approved these changes
Sep 24, 2026
leeandher
left a comment
leeandher
left a comment
Member
There was a problem hiding this comment.
this makes sense! i wonder if the provider should be encoding the routing data into the message by modifying the renderable, it's the only stage that has both the rendered output + target so it may be something to consider but im just thinking out loud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request parser walked a card action id, then a team id, then a tenant id to
find the integration, while the card action webhook handler only looked at the
card action id and can_infer_integration only looked at the first two. Cards
built by the notification platform cannot embed an integration id, since the
renderer has no access to the target it is being sent to, so every caller needs
the full chain.
Express the chain once as an ordered list of integration_service filters and
derive all three callers from it, so a request identified only by its tenant --
an action submitted from a personal chat -- resolves and is dispatched to a
cell rather than falling through to the control silo.