-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
ref(seer): Gate Seer access on not being self-hosted #125161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NicoHinderling
wants to merge
4
commits into
master
Choose a base branch
from
ref/seer-availability-helpers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−6
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
79fb485
ref(seer): Gate Seer access on not being self-hosted
NicoHinderling 7ccea37
ref(seer): Add areAiFeaturesAllowed util with self-hosted check
NicoHinderling cf6403b
test(seer): Pin SaaS mode in tests that reach has_seer_access
NicoHinderling 3832781
test(seer): Pin SaaS mode on every test class reaching has_seer_access
NicoHinderling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import {OrganizationFixture} from 'sentry-fixture/organization'; | ||
|
|
||
| import {ConfigStore} from 'sentry/stores/configStore'; | ||
| import {areAiFeaturesAllowed} from 'sentry/utils/seer/areAiFeaturesAllowed'; | ||
|
|
||
| describe('areAiFeaturesAllowed', () => { | ||
| beforeEach(() => { | ||
| ConfigStore.set('isSelfHosted', false); | ||
| }); | ||
|
|
||
| it('allows when flagged, not hidden, and not self-hosted', () => { | ||
| const organization = OrganizationFixture({ | ||
| features: ['gen-ai-features'], | ||
| hideAiFeatures: false, | ||
| }); | ||
| expect(areAiFeaturesAllowed(organization)).toBe(true); | ||
| }); | ||
|
|
||
| it('denies without the flag', () => { | ||
| const organization = OrganizationFixture({features: [], hideAiFeatures: false}); | ||
| expect(areAiFeaturesAllowed(organization)).toBe(false); | ||
| }); | ||
|
|
||
| it('denies when the org hides AI features', () => { | ||
| const organization = OrganizationFixture({ | ||
| features: ['gen-ai-features'], | ||
| hideAiFeatures: true, | ||
| }); | ||
| expect(areAiFeaturesAllowed(organization)).toBe(false); | ||
| }); | ||
|
|
||
| it('denies on self-hosted', () => { | ||
| ConfigStore.set('isSelfHosted', true); | ||
| const organization = OrganizationFixture({ | ||
| features: ['gen-ai-features'], | ||
| hideAiFeatures: false, | ||
| }); | ||
| expect(areAiFeaturesAllowed(organization)).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import {ConfigStore} from 'sentry/stores/configStore'; | ||
| import type {Organization} from 'sentry/types/organization'; | ||
|
|
||
| export function areAiFeaturesAllowed( | ||
| organization: Pick<Organization, 'features' | 'hideAiFeatures'> | ||
| ): boolean { | ||
| return ( | ||
| !ConfigStore.get('isSelfHosted') && | ||
| !organization.hideAiFeatures && | ||
| organization.features.includes('gen-ai-features') | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the flag be removed here too? |
||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use
not is_self_hosted()directly? More clear than using is_seer_available since that could stand for whether org can sign up for seer or not.