ref(seer): Remove organizations:gen-ai-features feature flag - #125163
Open
NicoHinderling wants to merge 3 commits into
Open
NicoHinderling wants to merge 3 commits into
NicoHinderling wants to merge 3 commits into
Conversation
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
NicoHinderling
marked this pull request as ready for review
September 22, 2026 02:41
NicoHinderling
force-pushed
the
ref/migrate-gen-ai-features-call-sites
branch
from
September 22, 2026 02:47
4ec49fc to
738f341
Compare
NicoHinderling
force-pushed
the
ref/migrate-gen-ai-features-call-sites
branch
from
September 22, 2026 03:05
738f341 to
e36ada2
Compare
NicoHinderling
force-pushed
the
ref/remove-gen-ai-features-flag
branch
from
September 22, 2026 03:05
0bd67f5 to
eee8b4d
Compare
Contributor
Sentry Snapshot Testing
|
The flag was on for every SaaS and single-tenant cell and off only on self-hosted, where no flagpole config exists. With has_seer_access and areAiFeaturesAllowed now checking is_self_hosted directly, the flag no longer carries information. Remove the registration, the remaining two-step checks in autofix, issue summary, and the trace explorer AI endpoints, the bulk task feature lists, and the settings form gate. Self-hosted denials now say so instead of reporting a missing flag. The flagpole entry must be deleted only after this is deployed everywhere, since deleting it first would turn Seer off for all SaaS orgs.
Sentry tests run in self-hosted mode by default, so every test that enabled the flag now pins SENTRY_SELF_HOSTED=False, and tests that proved denial without the flag now run as self-hosted or hide AI features at the org level. The seer workflows endpoint tests neutralize the endpoint rate limiter, which the middleware skips on self-hosted but enforces once the class runs in SaaS mode. One autofix utils test only passed because the flag masked a stale premise: replay rage click issues are a FRONTEND category and are eligible.
Remove the flag from every spec fixture and convert the tests that asserted hidden AI surfaces without the flag to self-hosted cases via ConfigStore.isSelfHosted. The group details spec now mocks the autofix and Seer onboarding endpoints its default org reaches once AI features are allowed without a flag.
NicoHinderling
force-pushed
the
ref/remove-gen-ai-features-flag
branch
from
September 22, 2026 03:14
eee8b4d to
e18965e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes the flag.
has_seer_accessandareAiFeaturesAllowednow reduce to "not self-hosted and not hideAiFeatures", the four remaining two-step sites checkis_seer_available()directly, the bulk task feature lists drop the flag, the org settings form gates its AI toggle on the self-hosted signal, and the registration intemporary.pygoes away. The now-unusedactorparameter on the two helpers is removed along with its twelve callers, and the explorer index eligibility block collapses to a single expression.Fixtures follow one rule: every place that enabled the flag now pins SaaS mode, and every test that proved denial without the flag now runs as self-hosted, or hides AI features at the org level where the assertion is about org access. Frontend specs drop the flag and use
ConfigStore.isSelfHostedfor the hidden cases. One autofix utils test only passed because the flag masked a stale premise: replay rage click issues are a FRONTEND category and are eligible, so that assertion is gone. Thenot_eligible.gen_ai_feature_disabledreason literal is kept as is because it is a metrics tag and an API field; renaming it is a separate, telemetry-aware change.Ordering matters for what comes after this. The flagpole entry must be deleted only once this PR is deployed everywhere, since removing it first would turn Seer off for every SaaS org. Local dev no longer needs the flag but does need
SENTRY_MODE = SentryMode.SAASinsentry.conf.py, which baresentry init --devdoes not set; getsentry's settings already do. New single-tenant cells get Seer by default rather than by being named in a flagpole segment.