fix(tests): Stop expecting an active repo to be reported as reactivated - #125350
Merged
Merged
Conversation
markstory
approved these changes
Sep 23, 2026
vaind
enabled auto-merge (squash)
September 23, 2026 18:55
wedamija
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_create_repositories__does_not_adopt_over_an_existing_rowfails on master.Two PRs landed on the same day without CI ever running them together. #125158 changed
create_repositoriesso a repository that is already active gets its config refreshed but is no longer reported as "reactivated". The test added in #123820 was written before that and still expected the active repository in the reactivated list.The test now expects an empty reactivated list. What it's actually there to check, that a hidden repository with the same external id is left alone, is unchanged.