fix(gocd): audit snuba-rs material allowlist - #8478
Closed
sentry-junior[bot] wants to merge 6 commits into
Closed
sentry-junior[bot] wants to merge 6 commits into
sentry-junior[bot] wants to merge 6 commits into
Conversation
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Co-Authored-By: Prajjwal Bhandari <prajjwal.bhandari@sentry.io>
Contributor
|
we're opting for a different approach. Closing tihs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit the
snuba-rsGoCD material filter and retain anincludesallowlist. GoCD represents allowlisting by inverting a single material filter, soincludesandignorecannot be combined.Add missing Rust runtime/deployment inputs to both GoCD templates:
.dockerignoredocker_entrypoint.pygocd/templates/bash/**/*, containing the scripts embedded in GoCD pipeline taskssnuba/consumers/consumer_config.py, which resolves configuration passed from Python into RustThe existing Rust sources, dataset configuration, settings, CLI, Dockerfile, and sentry-options schema paths remain included.
Options considered but not chosen
ignore: ['snuba/**/*.py']: rejected because it triggers the Rust deploy for many paths the old allowlist intentionally excluded.snuba/**with!exceptions: unsupported; GoCD material filters do not support gitignore-style negation.snuba/subtree except the shared Rust paths: rejected because it is brittle and silently changes behavior when new directories appear.includesandignore: unsupported; GoCD has one filter list plus an inversion flag.pyproject.tomlanduv.lock: considered during the audit, then intentionally omitted.scripts/rust-dummy-build.sh: considered because the Dockerfile copies it, then intentionally omitted.GoCD references
invertFilterincludesinstead ofignoreValidation
git diff --checkpyproject.toml,uv.lock, andscripts/rust-dummy-build.share absent from both allowlistsFull Jsonnet rendering was not run locally because
jb,jsonnetfmt,jsonnet-lint,jsonnet, andyqare unavailable; CI validates the rendered pipelines.via Prajjwal Bhandari.
--
View Junior Session [Sentry]