Repository navigation
ref: Remove generic metrics migrations and the cardinality analyzer - #8499
Merged
Merged
Conversation
Generic metrics is already deprecated, so drop its migration files. The loader now returns no migrations, matching how the sessions group was removed. Tests that depended on generic metrics migrations now use the metrics group or are dropped.
MeredithAnya
approved these changes
Sep 28, 2026
phacops
enabled auto-merge (squash)
September 28, 2026 21:35
The sets, distributions, and gauges storage sets have no storages, migrations, or code references left, so drop them from the cluster settings.
…storage set Drop the generic_metrics migration group, the generic_metrics_counters storage set, and the admin Cardinality Analyzer tool that queried the leftover generic metrics counters tables. Tests that used generic metrics as a fixture now use metrics or profiles.
phacops
changed the title
…ent settings The cardinality-report cronjob ran the spans cardinality analyzer, which was removed in #7955. Rename the CARDINALITY_ANALYZER ClickHouse client settings to OUTCOMES_ANALYZER since the Outcomes Analyzer is their only remaining user.
phacops
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes what was left of generic metrics after #8474: the migration files, the
generic_metricsmigration group, allgeneric_metrics_*storage sets in the cluster settings, and the admin Cardinality Analyzer tool, which only queried the leftover generic metrics tables.snuba migrationsand snuba-admin no longer recognize thegeneric_metricsgroup. Rows for it already inmigrations_localare ignored, because the runner only reads status for active groups. The ClickHouse tables themselves are not dropped here. The admin app loses the Cardinality Analyzer tab, its/cardinality_queriesand/cardinality_queryendpoints, theCardinalityAnalyzerrole, and that role's IAM binding.The
cardinality-reportcronjob is also removed from the deploy script. It ran the spans cardinality analyzer, whose code was removed in #7955. TheCARDINALITY_ANALYZERClickHouse client settings are renamed toOUTCOMES_ANALYZER, since the Outcomes Analyzer is their only remaining user. The settings values are unchanged.Tests that used generic metrics as a stand-in group or storage set now use
metricsorprofiles. The historical-import test for a generic metrics migration and the unusedgenmetrics_dbfixture are gone.