Skip to content

chore: migrate to actions/create-github-app-token - #517

Merged
joshuarli merged 2 commits into
mainfrom
chore/migrate-off-action-github-app-token
Sep 21, 2026
Merged

joshuarli merged 2 commits into
mainfrom
chore/migrate-off-action-github-app-token

Conversation

with:
app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }}
client-id: ${{ vars.SENTRY_INTERNAL_APP_ID }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The lint.yml workflow was updated to use client-id, but the variable vars.SENTRY_INTERNAL_APP_ID likely still contains a numeric App ID, not the required string Client ID.
Severity: HIGH

Suggested Fix

Verify that the repository variable SENTRY_INTERNAL_APP_ID contains the string-based Client ID (e.g., Iv...) and not the numeric App ID. For clarity, consider renaming the variable to SENTRY_INTERNAL_APP_CLIENT_ID to match its contents and the naming convention used in other workflows.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: .github/workflows/lint.yml#L30

Potential issue: The `lint.yml` workflow was migrated to use the
`actions/create-github-app-token` action, which requires a `client-id` input. The
workflow now passes the `vars.SENTRY_INTERNAL_APP_ID` variable to this `client-id`
parameter. However, the variable name suggests it still holds a numeric App ID, not the
string-formatted Client ID that the action expects. App IDs and Client IDs are different
identifiers. If the variable contains the old numeric ID, the action will fail during
authentication, causing the lint workflow to fail on every run. This will block the
auto-commit step from executing.

Did we get this right? 👍 / 👎 to inform future reviews.

@joshuarli
joshuarli merged commit ef11619 into main Sep 21, 2026
19 checks passed
@joshuarli
joshuarli deleted the chore/migrate-off-action-github-app-token branch September 21, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants