chore: migrate to actions/create-github-app-token - #517
Merged
Merged
Conversation
…e-github-app-token
This was referenced Sep 21, 2026
joshuarli
marked this pull request as ready for review
September 21, 2026 17:54
| with: | ||
| app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }} | ||
| private_key: ${{ secrets.SENTRY_INTERNAL_APP_PRIVATE_KEY }} | ||
| client-id: ${{ vars.SENTRY_INTERNAL_APP_ID }} |
There was a problem hiding this comment.
Bug: The lint.yml workflow was updated to use client-id, but the variable vars.SENTRY_INTERNAL_APP_ID likely still contains a numeric App ID, not the required string Client ID.
Severity: HIGH
Suggested Fix
Verify that the repository variable SENTRY_INTERNAL_APP_ID contains the string-based Client ID (e.g., Iv...) and not the numeric App ID. For clarity, consider renaming the variable to SENTRY_INTERNAL_APP_CLIENT_ID to match its contents and the naming convention used in other workflows.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: .github/workflows/lint.yml#L30
Potential issue: The `lint.yml` workflow was migrated to use the
`actions/create-github-app-token` action, which requires a `client-id` input. The
workflow now passes the `vars.SENTRY_INTERNAL_APP_ID` variable to this `client-id`
parameter. However, the variable name suggests it still holds a numeric App ID, not the
string-formatted Client ID that the action expects. App IDs and Client IDs are different
identifiers. If the variable contains the old numeric ID, the action will fail during
authentication, causing the lint workflow to fail on every run. This will block the
auto-commit step from executing.
Did we get this right? 👍 / 👎 to inform future reviews.
kedarv
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates off
getsentry/action-github-app-token(deprecated) to the upstreamactions/create-github-app-tokenaction.Related PRs (migration off
getsentry/action-github-app-token)Tracking issue: getsentry/action-github-app-token#104