fix(pi): Confine file tools to checkout - #513
Merged
Merged
Conversation
gricha
marked this pull request as ready for review
August 22, 2026 02:59
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good to me. Overriding the Pi built-ins with same-name custom tools is the right lever, and the pre-execute boundary covers the failure mode from traces (root searches, .. traversal, and out-of-checkout symlinks) without changing caller-provided tools. The repo-root vs invocation-directory behavior for local file context is clear, and the new tests lock the important cases in.
gricha
force-pushed
the
fix/confine-pi-file-tools
branch
from
August 22, 2026 03:03
ce70e77 to
c4a2f55
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Prevent Pi read and search tools from traversing outside the active checkout. Mistaken root searches can otherwise turn into very long Warden runs. Preserve local behavior by using the Git root when available and the invocation directory otherwise. Co-Authored-By: GPT-5.6 Sol <noreply@anthropic.com>
gricha
force-pushed
the
fix/confine-pi-file-tools
branch
from
August 24, 2026 16:04
c4a2f55 to
6a9f712
Compare
Execute Pi file tools with the canonical path that passed checkout confinement. This prevents Pi from reinterpreting alternate path syntax after validation and escaping the checkout. Co-Authored-By: GPT-5.6 Sol <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confine Pi read, grep, find, and ls tools to the active checkout and return repository-relative guidance when a path escapes it.
Sentry traces showed mistaken root-level searches crawling the runner filesystem for many minutes. Hard confinement stops those calls before traversal begins, including parent traversal and symlinks that resolve outside the checkout.
The canonical path that passes confinement is now the exact path executed by Pi. This prevents Pi from reinterpreting
@,~, orfile://syntax after validation.GitHub Actions remains bounded by GITHUB_WORKSPACE. Local Git runs use the repository root even when invoked from a subdirectory, while non-Git file runs use the invocation directory. Caller-provided custom tools keep their existing behavior.