BUG-57023: upgrade react-router-dom to ^7.18.0 to remediate react-router arbitrary constructor injection vulnerability - #14
Draft
midnight-clue[bot] wants to merge 1 commit into
Conversation
…7j-9hxr-rhxg Co-Authored-By: Milan Stovicek <milan.stovicek@getyourguide.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
Dependabot alert tchiotludo#72 on getyourguide/akhq reports that
react-router(a transitive dependency ofreact-router-dom) is vulnerable in the range >= 6.4.0, < 7.18.0 (GHSA-337j-9hxr-rhxg, medium severity — arbitrary constructor injection). The currentclient/package.jsonpinnedreact-router-domat^7.16.0, which resolved to a vulnerablereact-routerversion. See BUG-57023.Solution
Since
react-routeris a direct dependency ofreact-router-dom, the clean fix is to bumpreact-router-domto^7.18.0inclient/package.json(rather than adding a manual npm override), which pulls in the patchedreact-router >= 7.18.0. Rannpm installinsideclient/to regenerateclient/package-lock.jsonwith the patched dependency tree. No application code changes were required.Verification
react-router-domupgraded from^7.16.0to^7.18.0inclient/package.jsonclient/package-lock.jsonregenerated insideclient/; resolvedreact-routerversion confirmed at7.18.2(>= 7.18.0, outside the vulnerable range)react-router-domversion confirmed at7.18.2npm run lintandnpm testrun — pre-existing failures unrelated to this change (legacy.eslintrcvs. eslint v9 flat-config requirement, and a pre-existingSimulatetest setup issue) confirmed present ondevprior to this change; no new failures introduced by the dependency bump🔍 Braintrust trace