Repository navigation
fix: downloaded videos open instantly with silent background refresh - #15
Merged
Merged
Conversation
The watch screen gated rendering on the network detail query, so a
downloaded video sat behind a full-screen spinner (while its player —
created from the local file — was already autoplaying audio under it),
and the offline fallback only kicked in after the fetch had fully
failed (up to ~48s on a dead network).
- Render from local download metadata immediately; the query keeps
refreshing silently and swaps fresh metadata in without touching the
player (local uri stays the source, so playback never interrupts).
- fetchPage now throws HttpStatusError carrying the status; a 404/410
watch page notifies once ("video removed") but keeps the screen
open and playable. Other network failures stay silent when offline
data is shown; without a download the error screen shows the
specific removed message.
- videoRemoved strings for all five locales + a fetchPage status test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watch screen gated rendering on the network detail query, so a downloaded video sat behind a full-screen spinner (while its player — created from the local file — was already autoplaying audio under it), and the offline fallback only kicked in after the fetch had fully failed (up to ~48s on a dead network).