Add password support - #1
Open
MohamedAshref371 wants to merge 4 commits into
Open
MohamedAshref371 wants to merge 4 commits into
MohamedAshref371 wants to merge 4 commits into
Conversation
Author
|
I tested it on the following archives: 1- ZIP archive without a password. Password: 123 |
Author
|
Separated the extractSlow call to explicitly handle the password and non-password cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Password Parameter Handling
During testing and reviewing the internal code, it was confirmed that passing
nullas the password is handled correctly in both cases:SevenZip.openInArchiveinopenmethodBased on the internal code, it appears that passing the password as
nullwill automatically call the method that does not have a password parameter.item.extractSlowingetFilemethodTesting showed that there is no issue with passing the
passwordparameter asnull. It is handled the same way as callingitem.extractSlowwithout passing the password parameter.Therefore, passing null as the password is safe and does not require separate handling in these cases.